Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: bump ducktape to latest of 0.11.x #23570

Merged
merged 4 commits into from
Oct 3, 2024
Merged

tests: bump ducktape to latest of 0.11.x #23570

merged 4 commits into from
Oct 3, 2024

Conversation

ivotron
Copy link
Member

@ivotron ivotron commented Sep 30, 2024 •
edited
Loading

(re-creating #23477 since it "got stuck" in BK)

The fork that redpanda-data maintains has been updated and a new https://github.com/redpanda-data/ducktape/tree/0.11.x-redpanda branch contains the latest version of ducktape. This PR updates the reference of ducktape's version to the current tip of this branch. The version of kafkatest also is updated as part of this.

fixes https://redpandadata.atlassian.net/browse/PESDLC-2080

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

@ivotron
dt/deps: bump ducktape to latest of 0.11.x
f420d38 
The fork that redpanda-data maintains has been updated and a new
https://github.com/redpanda-data/ducktape/tree/0.11.x-redpanda branch
contains the latest version of ducktape. This commit points to the
current tip of that branch.

Signed-off-by: Ivo Jimenez <ivo@redpanda.com>
@ivotron
dt/deps: use pyyaml's version from ducktape
0e59775 
Stop explicitly installing it and instead use whatever version ducktape
points to.

Signed-off-by: Ivo Jimenez <ivo@redpanda.com>
@ivotron
dt/deps: bump kafkatest to latest of upstream
b80644c 
This is needed to reconcile dependencies between ducktape and kafkatest,
which before this were pointing to different versions of the `requests`
package.

Signed-off-by: Ivo Jimenez <ivo@redpanda.com>
@ivotron
dt/deps: cosmetic change to please the py linter
a066436 
Signed-off-by: Ivo Jimenez <ivo@redpanda.com>
@ivotron ivotron marked this pull request as draft September 30, 2024 20:03
@ivotron
Copy link
Member Author

ivotron commented Oct 1, 2024

/cdt
num_nodes=140

@ivotron ivotron marked this pull request as ready for review October 2, 2024 23:01
@ivotron
Copy link
Member Author

ivotron commented Oct 3, 2024

turns out all the CDT failures are known flakies. I initially got confused because they were marked as failures, so they weren't retried, but then realized that there is no auto-retry in CDT

@ivotron ivotron requested a review from andrewhsu October 3, 2024 00:14
jackietung-redpanda
jackietung-redpanda approved these changes Oct 3, 2024
View reviewed changes
tests/setup.py
'pytest==7.1.2', 'jump-consistent-hash==3.2.0',
'azure-storage-blob==12.14.1',
'kafkatest@git+https://github.com/apache/kafka.git@3.2.0#egg=kafkatest&subdirectory=tests',
'ducktape@git+https://github.com/redpanda-data/ducktape.git@7772220005a27957d3a796de0e19d3c51eb61f6a',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: using a tag would be really nice (we can add our own tag), for readability and for indicating immutability.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll move to using tags after we simplify the fork

tests/setup.py
'protobuf==4.21.8', 'fastavro==1.4.9', 'falcon==3.1.3',
'psutil==5.9.0', 'numpy==1.22.3', 'pygal==3.0', 'pytest==7.1.2',
'jump-consistent-hash==3.2.0', 'azure-storage-blob==12.14.1',
'kafkatest@git+https://github.com/apache/kafka.git@e146c7c9164c4e8817fe891ac9d7d1661889b2b4#egg=kafkatest&subdirectory=tests',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a public repo, so I guess we cannot add a tag!

andrewhsu
andrewhsu approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chatted with ivo about backport strategies: since each of the supported branches can run with older versions of ducktape, may want to skip backporting if it causes too many issues

@andrewhsu
Copy link
Member

andrewhsu commented Oct 3, 2024 •
edited
Loading

btw, related PR to the 0.11.x-redpanda branch: redpanda-data/ducktape#35

@ivotron
Copy link
Member Author

ivotron commented Oct 3, 2024

full local DT run in https://buildkite.com/redpanda/redpanda/builds/55485 (errors are known flaky unit/fixture tests).
CDT run in https://buildkite.com/redpanda/redpanda/builds/55500 (with known flakies as well).

force-merging

@ivotron ivotron merged commit aa51f0d into redpanda-data:dev Oct 3, 2024
20 of 24 checks passed
@ivotron ivotron deleted the bump-ducktape-to-latest-of-upstream/0.11.x branch October 3, 2024 19:30
@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich vbotbuildovich mentioned this pull request Oct 3, 2024
Merged
@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.1.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-23570-v24.1.x-12 remotes/upstream/v24.1.x
git cherry-pick -x f420d38c58 0e59775175 b80644cea2 a0664363c6

Workflow run logs.

@vbotbuildovich vbotbuildovich mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 4, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackietung-redpanda jackietung-redpanda jackietung-redpanda approved these changes

@andrewhsu andrewhsu andrewhsu approved these changes

@michael-redpanda michael-redpanda Awaiting requested review from michael-redpanda

@gousteris gousteris Awaiting requested review from gousteris

@dotnwat dotnwat Awaiting requested review from dotnwat

@pgellert pgellert Awaiting requested review from pgellert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivotron @andrewhsu @vbotbuildovich @jackietung-redpanda