tests: ability to dynamically parametrize cloud_storage_type #9283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gousteris
force-pushed
the
fix-redpanda-8704
branch
2 times, most recently
from
1893c52 to
ef4042a
Compare
gousteris
changed the title
gousteris
force-pushed
the
fix-redpanda-8704
branch
11 times, most recently
from
3d83eb1 to
407f3d5
Compare
andrewhsu
previously approved these changes
Mar 14, 2023
There was a problem hiding this comment.
LGTM
pre-emptive lgtm because tests are green and this PR now points to the changes that will be brought in with redpanda-data/ducktape#24
nit: update the git commit to the merge commit after PR 24 merges, but not a blocker for this PR
gousteris
force-pushed
the
fix-redpanda-8704
branch
from
407f3d5 to
8241caa
Compare
Replaced `parametrized` with `matrix` decorator, and the cloud_storage_type holds the parametrization needed for each host type. For example for cdt runs on aws, the matrix will only contain s3 as cloud storage type. same for gcp or azure. For regular tests (host=docker container), it parametrizes with both s3 and abs ref redpanda-date/redpanda#8704
To be able to mark tests with empty list of `matrix` parametrization as `ignore` ref redpanda#8704 redpanda-data/ducktape#24
gousteris
force-pushed
the
fix-redpanda-8704
branch
from
8241caa to
773b44f
Compare
VladLazar
approved these changes
Mar 16, 2023
| @@ -169,6 +167,46 @@ def one_or_many(value): | |||
| return value | |||
|
|
|||
|
|
|||
| def get_cloud_storage_type(applies_only_on: list(CloudStorageType) = None, | |||
There was a problem hiding this comment.
Nit: the type hint doesn't match. Should be Optional[..]
The latest report I ran is https://ci-artifacts.dev.vectorized.cloud/vtools/6695/0186dfe2-dbea-4e04-869c-25850ec94a48/vbuild/ducktape/results/2023-03-14--001/report.html where there is no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
parametrizedwithmatrixdecorator,and the cloud_storage_type holds the parametrization
needed for each host type. For example for
cdt runs on aws, the matrix will only contain s3
as cloud storage type. same for gcp or azure.
For regular tests (host=docker container), it
parametrizes with both s3 and abs
Additionally, tests that are parametrized to run on a single
cloud storage type, will be explicitly excluded from the test
collection ref: https://github.com/redpanda-data/vtools/pull/1554/commits/131144e09460a07afc690dd4a1ab65a507b41f2d
ref #8704
Backports Required
Release Notes