Improve RedPen custom resource loading #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
February 23, 2016 10:32
…nsibility to provide a logging backend, but redpen-cli should have one by itself
…dCachedFromResource() doesn't find the file
… to resolve custom dictionaries and other files in Validators
… private in Validator
… of them consistent
…ir and look for files in both
|
Hmm... Removing ensureFileIsInsideRedPenHomeOrWorkingDirectory looks unsafe... @yusuke Can you please tell me your idea on the changes? |
|
findFile() already looks in particular places to resolve the files or throws the same exception as ensureFileIsInsideRedPenHomeOrWorkingDirectory() did if the file is not found. There seems to be no other reason of restricting where the files should be located, isn't it? The method looked obsolete to us. |
|
@cbxp I would like to know where is tests for restricting the js directory is throwing the exception. |
|
We have added the missing tests |
takahi-i
added a commit
that referenced
this pull request
Feb 26, 2016
Improve RedPen custom resource loading
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom resources will now be looked for from 3 places:
All Validators now have access to this functionality via Validator.findFile().
All existing validators were updated to use it.
WARNING: This pull request depends (contains the same changes) on this one #550, please merge #550 first.
Review changes starting from this commit: codeborne@042cfdc