Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RedPen custom resource loading #551

Merged
merged 18 commits into from
Feb 26, 2016
Merged

Improve RedPen custom resource loading #551

merged 18 commits into from
Feb 26, 2016

Commits on Feb 23, 2016

  1. redpen-core doesn't actually depend on commons-cli

    Anton Keks, Dmitri Ess committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    5562e07 View commit details
    Browse the repository at this point in the history

  2. redpen-core shouldn't depend on logback, because it is client's respo… 

    …nsibility to provide a logging backend, but redpen-cli should have one by itself
    Anton Keks, Dmitri Ess committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    165863b View commit details
    Browse the repository at this point in the history

  3. ValidatorConfiguration.equals() must compare attributes

    Anton Keks, Dmitri Ess committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    caa1046 View commit details
    Browse the repository at this point in the history

  4. implement Configuration.toString()

    Anton Keks, Dmitri Ess committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    9f27cce View commit details
    Browse the repository at this point in the history

  5. add convenience Configuration.builder() methods

    Anton Keks, Dmitri Ess committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    5fc3999 View commit details
    Browse the repository at this point in the history

  6. use more convenient Configuration.builder() method in tests

    Anton Keks, Dmitri Ess committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    5548456 View commit details
    Browse the repository at this point in the history

  7. remove unused variable

    Anton Keks, Dmitri Ess committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    5554b05 View commit details
    Browse the repository at this point in the history

  8. add convenient method Document.builder() and use it in tests

    Anton Keks, Dmitri Ess committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    1c92330 View commit details
    Browse the repository at this point in the history

  9. better support for new languages: do not fail if DictionaryLoader.loa… 

    …dCachedFromResource() doesn't find the file
    Anton Keks, Dmitri Ess committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    ed6bd6e View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2016

  1. introduce getHome() and findFile() to Configuration to make it easier… 

    … to resolve custom dictionaries and other files in Validators
    Anton Keks, Dmitri Ess committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    042cfdc View commit details
    Browse the repository at this point in the history

  2. delegate Configuration.findFile() from Validator to keep globalConfig… 

    … private in Validator
    Anton Keks, Dmitri Ess committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    0137727 View commit details
    Browse the repository at this point in the history

  3. resolve all custom files using Validator.findFile() to make resolving… 

    … of them consistent
    Anton Keks, Dmitri Ess committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    8f1280d View commit details
    Browse the repository at this point in the history

  4. for backwards compatibility, separate home dir and config file base d… 

    …ir and look for files in both
    Anton Keks, Dmitri Ess committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    2f1a42e View commit details
    Browse the repository at this point in the history

  5. ConfigurationLoader now initializes base dir to the parent of loaded … 

    …file
    Anton Keks, Dmitri Ess committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    cbe0dbf View commit details
    Browse the repository at this point in the history

  6. make tests of working directory also work under Maven

    Anton Keks, Dmitri Ess committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    d231cb2 View commit details
    Browse the repository at this point in the history

  7. add optional base parameter to loadFromResource() and loadFromString()

    Anton Keks, Dmitri Ess committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    c2d7b53 View commit details
    Browse the repository at this point in the history

  8. for backwards compatibility: do not crash if JavaScript directory is … 

    …not found
    Anton Keks, Dmitri Ess committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    ef3b6fa View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2016

  1. add tests for findFile() not finding the requested file

    Anton Keks, Dmitri Ess committed Feb 26, 2016
    Configuration menu
    Copy the full SHA
    13388f4 View commit details
    Browse the repository at this point in the history