Advanced tutorial: limit try blocks to API calls #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 30, 2019 09:19
This avoids catching exceptions that occur during a dispatch.
|
Deploy preview for redux-starter-kit-docs ready! Built with commit 2141596 https://deploy-preview-200--redux-starter-kit-docs.netlify.com |
|
I just finished updating the tutorial examples and pages to use RSK 1.0. I opted not to rewrite the actual data fetching code with your changes, but I did add a note on ways to do error handling in async thunks. See #245 . Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the starter kit, it really helped me get going with redux. This is a PR reflecting our discussion here: https://twitter.com/acemarke/status/1171438698337947651
IMO the slight extra verbosity is worth avoiding the pain of trying to debug what's going on when the dispatch throws (for newcomers especially, speaking from personal experience!).