Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorials for v0.8 #213

Merged
merged 4 commits into from
Oct 13, 2019
Merged

Conversation

markerikson
Copy link
Collaborator

@markerikson markerikson commented Oct 13, 2019

Initial tutorial changes to match 0.8.

So far this only includes the slice? -> name changes.

The intermediate and advanced tutorial repos still need to be rewritten, and at that point we'll have to fix up the commit links here to point to the new commits, and redo the CodeSandbox sandboxes as well.

I also based this PR off of #174 , so once that gets merged we'll need to rebase this off v0.8-integration and force-push.

@netlify
Copy link

netlify bot commented Oct 13, 2019

Deploy preview for redux-starter-kit-docs ready!

Built with commit 4d01660

https://deploy-preview-213--redux-starter-kit-docs.netlify.com

@markerikson markerikson marked this pull request as ready for review October 13, 2019 22:30
@markerikson
Copy link
Collaborator Author

Given that I've got to actually push 0.8 out the door before I can rewrite the commits, I think the plan will be to merge this to master and release 0.8 first. The content will be correct, it'll only be the links to the specific commits that will be outdated (and the commit contents).

Once the 0.8 release is out, I can go rewrite the tutorial commits using 0.8, push those, and fix up the commit links.

Also, I want to at least integrate a note about async try/catch per #200 .

@markerikson markerikson merged commit 555d9b1 into v0.8-integration Oct 13, 2019
@markerikson markerikson deleted the docs/update-tutorials-v0.8 branch October 13, 2019 22:32
@markerikson markerikson mentioned this pull request Oct 13, 2019
markerikson added a commit that referenced this pull request Oct 15, 2019
* Create slice changes (#197)

* Include case reducers in createSlice result (#209)

* Fix missing name field in type test

* Include provided case reducers in createSlice output

- Added `caseReducers` field to the createSlice return object
- Added test and type test for returned case reducer
- Removed "Enhanced" terminology from types, and replaced with
  "CaseReducerWithPrepare" and "CaseReducerDefinition"
- Restructured logic to only loop over reducer names once, and
  check case reducer definition type once per entry

* Add type tests for correct case reducer export inference

* Rewrite caseReducers types for correct inference of state + action

* Add type test for reducers with prepare callback

* Fix type inference for actions from reducers w/ prepare callbacks

* Clean up type names and usages

* Use a generic State type in ActionForReducer

* Re-switch Slice generics order

* Use `void` instead of `any` for undefined payloads (#174)

* Change default createAction payload type to void to make it required

* Fix createAction type tests per review

* Update tutorials for v0.8 (#213)

* Update basic tutorial with createSlice changes

* Update intermediate tutorial with createSlice changes

* Update advanced tutorial with createSlice changes

* Change existing commit links to point to reduxjs org repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant