Merge pull request #44 from emmenko/read-state-by-store

Allow to read state by store on action creator callback
reduxjs · Jun 5, 2015 · f8d72b0 · f8d72b0
2 parents 319377c + ac1be83
commit f8d72b0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -62,10 +62,10 @@ export function incrementAsync() {
   };
 }
 
-// Could also look into state in the callback form
+// Could also read state of a store in the callback form
 export function incrementIfOdd() {
-  return (dispatch, state) => {
-    if (state.counterStore % 2 === 0) {
+  return (dispatch, read) => {
+    if (read(counterStore) % 2 === 0) {
       return;
     }
 

diff --git a/examples/counter/actions/CounterActions.js b/examples/counter/actions/CounterActions.js
@@ -2,6 +2,7 @@ import {
   INCREMENT_COUNTER,
   DECREMENT_COUNTER
 } from '../constants/ActionTypes';
+import { counterStore } from '../stores';
 
 export function increment() {
   return {
@@ -10,8 +11,8 @@ export function increment() {
 }
 
 export function incrementIfOdd() {
-  return (dispatch, state) => {
-    if (state.counterStore.counter % 2 === 0) {
+  return (dispatch, read) => {
+    if (read(counterStore) % 2 === 0) {
       return;
     }
 

diff --git a/src/createDispatcher.js b/src/createDispatcher.js
@@ -121,14 +121,19 @@ export default function createDispatcher() {
       const action = actionCreator(...args);
       if (typeof action === 'function') {
         // Callback-style action creator
-        action(dispatch, currentState);
+        action(dispatch, read);
       } else {
         // Simple action creator
         dispatch(action);
       }
     };
   }
 
+  // Allow to read the state of a store
+  function read(store) {
+    return currentState[getStoreKey(store)];
+  }
+
   return {
     wrapActionCreator,
     observeStores,