Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to read state by store on action creator callback #44

Merged
merged 1 commit into from
Jun 5, 2015

Conversation

emmenko
Copy link
Contributor

@emmenko emmenko commented Jun 5, 2015

@gaearon Is that what you meant? It looked too much easier to implement... O.O

@gaearon
Copy link
Contributor

gaearon commented Jun 5, 2015

Yeah, this seems right! Let's keep this out of the examples though. It's fine in README, I might have a proper example later. It's OK that the method is unused for now.

@@ -1,9 +1,9 @@
redux
=========================

An experiment in fully hot-reloadable Flux.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace is significant in markdown files. Otherwise it'll remove the line breaks where I want them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I have "trim_trailing_white_space_on_save": true on my sublime :)
Will try to revert it...

@emmenko
Copy link
Contributor Author

emmenko commented Jun 5, 2015

Regarding the example, sure, I was just making sure it was working :)

I'll revert that as well

@emmenko
Copy link
Contributor Author

emmenko commented Jun 5, 2015

@gaearon done :)

@gaearon
Copy link
Contributor

gaearon commented Jun 5, 2015

Good, can you please squash into a single commit?



Keep trailing whitespaces

Keep async action out of example for now
@emmenko
Copy link
Contributor Author

emmenko commented Jun 5, 2015

Here we go :)

gaearon added a commit that referenced this pull request Jun 5, 2015
Allow to read state by store on action creator callback
@gaearon gaearon merged commit f8d72b0 into reduxjs:master Jun 5, 2015
@gaearon
Copy link
Contributor

gaearon commented Jun 5, 2015

👍

@gaearon
Copy link
Contributor

gaearon commented Jun 5, 2015

Out in 0.7.0.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants