Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Meta PR] Convert to TypeScript #3536

Merged
merged 47 commits into from
Sep 6, 2019
Merged

[Meta PR] Convert to TypeScript #3536

merged 47 commits into from
Sep 6, 2019

Commits on Aug 15, 2019

  1. scaffolding for typescript (#3504) 

    * scaffolding for typescript

* add jest types so tests will compile

* remove rollup-plugin-typescript2, probably don't need it

* add missing eslint-import

* fix linting errors
    @cellog @timdorr
    cellog authored and timdorr committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    76d1f98 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2019

  1. migrate applyMiddleware test to typescript (#3505)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    9ab13e1 View commit details
    Browse the repository at this point in the history

  2. migrate bindActionCreators test to typescript (#3506)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    b67654c View commit details
    Browse the repository at this point in the history

  3. convert the compose test to typescript (#3509)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    577dd90 View commit details
    Browse the repository at this point in the history

  4. fix replaceReducer type (#3507) 

    * fix replaceReducer type

* remove extraneous type

* Update the JSDoc so IDEs don't complain.

* new test for replaceReducers


Co-authored-by: Tim Dorr <timdorr@users.noreply.github.com>
    @cellog @timdorr
    cellog and timdorr committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    2c1af36 View commit details
    Browse the repository at this point in the history

  5. convert combineReducers test to typescript (#3508)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    9a62a31 View commit details
    Browse the repository at this point in the history

  6. migrate index.js to typescript (#3513)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    f6a2122 View commit details
    Browse the repository at this point in the history

  7. convert the createStore test to typescript - and run the tests (#3510)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    e48c389 View commit details
    Browse the repository at this point in the history

  8. convert utils/isPlainObject test to typescript (#3511)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    601d54d View commit details
    Browse the repository at this point in the history

  9. migrate warning.spec.ts to typescript (#3512)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    2f2cd31 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2019

  1. migrate typescript.spec.ts to typescript (#3516)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    a8b133c View commit details
    Browse the repository at this point in the history

  2. migrate test helpers to typescript (#3515)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    20f604d View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2019

  1. Resolve TS extensions with node-resolve plugin (#3517)

    @nickserv @timdorr
    nickserv authored and timdorr committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    2e15b68 View commit details
    Browse the repository at this point in the history

  2. TypeScript: Fix linter configuration for test files (#3518) 

    * Fix linter configuration for test files

* Add separate ESLint config to test/typescript

* Also lint TypeScript files in examples
    @nickserv @timdorr
    nickserv authored and timdorr committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    aa8b325 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2019

  1. add a new test to verify replaceReducer typings work (#3521)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    e5fba83 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2019

  1. fix typescript config for rollup (#3519) 

    * fix typescript config for rollup

* h/t @timdorr remove need for .rpt2_cache ignore
    @cellog @timdorr
    cellog authored and timdorr committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    a68f48e View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2019

  1. fix warning in test (#3527)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    4f7ff64 View commit details
    Browse the repository at this point in the history

  2. Use new default cache root (#3528)

    @nickserv @timdorr
    nickserv authored and timdorr committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    9c8e440 View commit details
    Browse the repository at this point in the history

  3. convert bindActionCreators to typescript (#3530)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    e638c96 View commit details
    Browse the repository at this point in the history

  4. Convert applyMiddleware.js to typescript (#3529) 

    * convert applyMiddleware.js to typescript

* vastly improve the definition of middleware types
    @cellog @timdorr
    cellog authored and timdorr committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    aa6d410 View commit details
    Browse the repository at this point in the history

  5. convert compose to typescript (#3532)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    7a669b9 View commit details
    Browse the repository at this point in the history

  6. convert utils/ to typescript (#3534)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    b0e8219 View commit details
    Browse the repository at this point in the history

  7. convert createStore to typescript (#3533)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    9b70f1c View commit details
    Browse the repository at this point in the history

  8. convert combineReducers to typescript (#3531) 

    * convert combineReducers to typescript

* use idiomatic JS
    @cellog @timdorr
    cellog authored and timdorr committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    ff8af9f View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2019

  1. remove unused type (#3538)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    4132d41 View commit details
    Browse the repository at this point in the history

  2. merge type definitions from index.d.ts into combineReducers (#3539)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    c43fc3a View commit details
    Browse the repository at this point in the history

  3. export types, prepare TS config for migrating files (#3537) 

    * fix config

* export types

* use export from, reorganize

* fix stupid eslint rule breakage
    @cellog @timdorr
    cellog authored and timdorr committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    7b0c760 View commit details
    Browse the repository at this point in the history

  4. extract store types from index.d.ts (#3540) 

    * extract store types from index.d.ts

* move storeTypes.ts into types/

* Rename storeTypes.ts to store.ts


Co-authored-by: Tim Dorr <timdorr@users.noreply.github.com>
    @cellog @timdorr
    cellog and timdorr committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    146791c View commit details
    Browse the repository at this point in the history

  5. extract action types from index.d.ts (#3541)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    7bd5846 View commit details
    Browse the repository at this point in the history

  6. Extract reducer types from index.d.ts (#3542) 

    * extract reducer types from index.d.ts

* fix rebase
    @cellog @timdorr
    cellog authored and timdorr committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    8735e56 View commit details
    Browse the repository at this point in the history

  7. remove duplicate types (they live in types/reducers.ts) (#3544)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    0c70abc View commit details
    Browse the repository at this point in the history

  8. extract middleware types from index.d.ts (#3543) 

    * extract middleware types from index.d.ts

* move PreloadedState/CombinedState into types/store.ts
    @cellog @timdorr
    cellog authored and timdorr committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    956b0e9 View commit details
    Browse the repository at this point in the history

  9. use the new action types (#3545)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    addcacb View commit details
    Browse the repository at this point in the history

  10. fix type import of CombinedState (#3546) 

    * fix type import

* Spacing


Co-authored-by: Tim Dorr <timdorr@users.noreply.github.com>
    @cellog @timdorr
    cellog and timdorr committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    ed4f090 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2019

  1. import types from src/types (#3549)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 31, 2019
    Configuration menu
    Copy the full SHA
    35f2e1a View commit details
    Browse the repository at this point in the history

  2. use new middleware types from types/middleware.ts (#3547)

    @cellog @timdorr
    cellog authored and timdorr committed Aug 31, 2019
    Configuration menu
    Copy the full SHA
    81329e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2019

  1. add missing type exports (#3556)

    @cellog @timdorr
    cellog authored and timdorr committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    40d9e1e View commit details
    Browse the repository at this point in the history

  2. use new reducer types from types/reducers.ts, store types from types/… 

    …store.ts (#3548)

* use new store types from types/store.ts

* use new reducer types from types/reducers.ts
    @cellog @timdorr
    cellog authored and timdorr committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    65afa45 View commit details
    Browse the repository at this point in the history

  3. fix typings of createStore and import of Reducer type (#3555)

    @cellog @timdorr
    cellog authored and timdorr committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    6d96545 View commit details
    Browse the repository at this point in the history

  4. fix combineReducers overload exports, and import of Reducer type (#3554)

    @cellog @timdorr
    cellog authored and timdorr committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    a450fbd View commit details
    Browse the repository at this point in the history

  5. fix import inside enhancers typescript test (#3559)

    @cellog @timdorr
    cellog authored and timdorr committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    dd6639a View commit details
    Browse the repository at this point in the history

  6. add overloads to compose.ts and applyMiddleware.ts (#3558) 

    * add overloads to compose.ts

* add applyMiddleware overload fixes
    @cellog @timdorr
    cellog authored and timdorr committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    8112c95 View commit details
    Browse the repository at this point in the history

  7. fixes to bindActionCreators overloads (#3552)

    @cellog @timdorr
    cellog authored and timdorr committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    dbc95c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. fix replaceReducer with a store enhancer (#3524) 

    * fix replaceReducer with a store enhancer

* remove erroneous restriction on StateExt

* remove the other extension - our store enhancer might add array functionality, for instance

* add reasonable defaults for Ext and StateExt

* fix state, add a test for non-object-based state

* add verification that store extension is also passed to replaceReducer

* better fix: set state default based on what base type it is

* fix array test

* fix typing of StateExt

* add mhelmerson example

* fix replaceReducer, so that it infers types, fix example test

* fix the weird type hacks in the test

* add final working example

* update based on PR type changes

* fix type

* update tests to reflect complete examples

* merge the changes from index.d.ts into types/store.ts

* extend store type

* much better approach: only extend the state when we have an extension

* fix typing issues not caught before

* add link to the place I learned about this
    @cellog @timdorr
    cellog authored and timdorr committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    066fa81 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. fully move away from index.d.ts (#3561) 

    * fully move away from index.d.ts

* build types into the types/ directory

* remove autogenerated types dir

* ignore auto-generated types

* better type building, also clean old definitions

* use types instead of typings

Co-Authored-By: Jed Mao <jedmao@users.noreply.github.com>

* Don't build declaration maps
    @cellog @timdorr
    cellog authored and timdorr committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    766f934 View commit details
    Browse the repository at this point in the history

  2. fix TSDoc comments (#3560)

    @jedmao @timdorr
    jedmao authored and timdorr committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    9e71b4c View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. Defer to rollup TS plugin to build types (#3564) 

    * Defer to rollup TS plugin to build types

* index.ts -> redux.js, redux.d.ts

* Only output one copy of the types.

This also puts them back into the types path. However, I don't know how to have them output as a single file bundle to match our other outputs.

* Remove the move


Co-authored-by: Tim Dorr <git@timdorr.com>
    @jedmao @timdorr
    jedmao and timdorr committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    d8417e8 View commit details
    Browse the repository at this point in the history