chore: remove aws-lambda #10450
Merged
chore: remove aws-lambda #10450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes `aws-lambda` as a `devDependency` from the packages it was being referenced in. The `aws-lambda` package is actually a CLI for deploying lambdas. The `@types/aws-lambda` package provides type definitions for what AWS makes available at run-time (i.e. the `"aws-lambda"` import path isn't meant to exist on disk).
Josh-Walker-GM
approved these changes
Apr 13, 2024
|
For reference, it looks like some of this was introduced way back in #3629 which is way before my time at redwood. It doesn't look like from the PR that removing this dependency will cause any issues - netlify should be fine I would think. |
Josh-Walker-GM
added
release:chore
|
all good, thanks a lot for fixing that up and taking a look 🥳 & yup i looked through the git history and nothing stood out, seems it just got added by habit when the types were added |
Josh-Walker-GM
added a commit
that referenced
this pull request
Apr 14, 2024
This removes `aws-lambda` as a `devDependency` from the packages it was being referenced in. The `aws-lambda` package is actually a CLI for deploying lambdas. The `@types/aws-lambda` package provides type definitions for what AWS makes available at run-time (i.e. the `"aws-lambda"` import path isn't meant to exist on disk). I searched the repo for usages of the `lambda` bin it provides and it doesn't look like there are any, so this was probably just added by mistake long ago --------- Co-authored-by: Josh GM Walker <56300765+Josh-Walker-GM@users.noreply.github.com>
dac09
added a commit
that referenced
this pull request
Apr 16, 2024
…-dbauth-middleware * 'main' of github.com:redwoodjs/redwood: chore(location): Accept URL-like object (#10467) fix(router): Remove barrel exports from router.tsx (#10464) chore(dbauth-mw): Refactor web side dbAuth creation (#10460) chore(router): Prevent circular dependency for namedRoutes (#10463) chore(router): route-validators: Better types and clean up comments (#10462) feat(server-auth): dbAuth 3/3 - handle login, logout, signup, etc. requests if forwarded from middleware (#10457) docs(router): Document new NavLink className replacement behavior (#10401) chore(refactor): Split the router out into smaller logical units (#10434) feat(server-auth): Part 1/3: dbAuth middleware support (web side changes) (#10444) chore(auth): Build: Put ESM at the root, and CJS in /cjs (#10458) fix(ssr): Successfully serve static assets like `favicon.png` (#10455) chore(deps): update chore (#10367) (docs) Fix useCache headers and links (#10451) chore: remove aws-lambda (#10450) chore(deps): update dependency typescript to v5.4.5 (#10452) feat(og-gen): Update implementation of useLocation | Update App template (#10441) feat(og-gen): Adds package and vite plugin for dynamic og generation (#10439)
dac09
added a commit
that referenced
this pull request
Apr 16, 2024
…g-gen-mw-p2 * 'main' of github.com:redwoodjs/redwood: chore(dbauth-mw): Refactor web side dbAuth creation (#10460) chore(router): Prevent circular dependency for namedRoutes (#10463) chore(router): route-validators: Better types and clean up comments (#10462) feat(server-auth): dbAuth 3/3 - handle login, logout, signup, etc. requests if forwarded from middleware (#10457) docs(router): Document new NavLink className replacement behavior (#10401) chore(refactor): Split the router out into smaller logical units (#10434) feat(server-auth): Part 1/3: dbAuth middleware support (web side changes) (#10444) chore(auth): Build: Put ESM at the root, and CJS in /cjs (#10458) fix(ssr): Successfully serve static assets like `favicon.png` (#10455) chore(deps): update chore (#10367) (docs) Fix useCache headers and links (#10451) chore: remove aws-lambda (#10450) chore(deps): update dependency typescript to v5.4.5 (#10452)
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Apr 18, 2024
* 'main' of github.com:redwoodjs/redwood: Revert "chore(location): Accept URL-like object" (redwoodjs#10473) RSC: Be consistent about inlining rollup input (redwoodjs#10472) chore(paths): Remove outdated comment (redwoodjs#10471) feat(server-auth): Update getAuthenticationContext to support cookies and tokens both (redwoodjs#10465) chore(location): Accept URL-like object (redwoodjs#10467) fix(router): Remove barrel exports from router.tsx (redwoodjs#10464) chore(dbauth-mw): Refactor web side dbAuth creation (redwoodjs#10460) chore(router): Prevent circular dependency for namedRoutes (redwoodjs#10463) chore(router): route-validators: Better types and clean up comments (redwoodjs#10462) feat(server-auth): dbAuth 3/3 - handle login, logout, signup, etc. requests if forwarded from middleware (redwoodjs#10457) docs(router): Document new NavLink className replacement behavior (redwoodjs#10401) chore(refactor): Split the router out into smaller logical units (redwoodjs#10434) feat(server-auth): Part 1/3: dbAuth middleware support (web side changes) (redwoodjs#10444) chore(auth): Build: Put ESM at the root, and CJS in /cjs (redwoodjs#10458) fix(ssr): Successfully serve static assets like `favicon.png` (redwoodjs#10455) chore(deps): update chore (redwoodjs#10367) (docs) Fix useCache headers and links (redwoodjs#10451) chore: remove aws-lambda (redwoodjs#10450) chore(deps): update dependency typescript to v5.4.5 (redwoodjs#10452)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
aws-lambdaas adevDependencyfrom the packages it was being referenced in.The
aws-lambdapackage is actually a CLI for deploying lambdas. The@types/aws-lambdapackage provides type definitions for what AWS makes available at run-time (i.e. the"aws-lambda"import path isn't meant to exist on disk).I searched the repo for usages of the
lambdabin it provides and it doesn't look like there are any, so this was probably just added by mistake long ago