Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.38rc] Fix netlify deploy: Cleans up dependencies for rwjs/api and rwjs/graphql #3629

Merged
merged 3 commits into from
Oct 25, 2021

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented Oct 25, 2021

This PR updates dependencies for @redwoodjs/api and @redwoodjs/graphql-server packages.

In particular, I used depcheck to figure out missing and unused dependecies, and here's what I did:

  1. Removed unused dependencies (I checked through the code), except where this dependency would be needed by the redwood app (e.g. prisma client)
  2. Added missing dependencies to api - this is why netlify deploys are failing in the RC (pascalcase module used in the new validations)

@dac09 dac09 changed the title Cleans up dependencies for rwjs/api and rwjs/graphql [v0.38rc] Fix netlify deploy: Cleans up dependencies for rwjs/api and rwjs/graphql Oct 25, 2021
@dac09 dac09 self-assigned this Oct 25, 2021
@thedavidprice
Copy link
Contributor

I agree this is likely the fix. I'm going to get this in and test deploy on canary (instead of running through local ZiSi process + check).

@dac09 I wonder if we should add the depcheck tool to our CI?

@thedavidprice thedavidprice merged commit b3416e4 into redwoodjs:main Oct 25, 2021
@dac09
Copy link
Collaborator Author

dac09 commented Oct 25, 2021

@dac09 I wonder if we should add the depcheck tool to our CI?

@thedavidprice thought about it, but we actually have to have some funky dependencies that are not technically required, but removing it would break apps. A good example is the core package, where none of the dependencies are actually needed, within the package, but we have it there so that the end redwood app has these as dependencies.

@dac09 dac09 deleted the fix/validation-deps branch October 25, 2021 16:54
@thedavidprice
Copy link
Contributor

Roger that. Thanks!

thedavidprice pushed a commit that referenced this pull request Oct 25, 2021
… rwjs/graphql (#3629)

* Add pascale case to rwjs/api

* Cleans up dependencies for rwjs/api using depcheck

* Cleanup graphql-server types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants