Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update React to latest canary 19.x #10496

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Apr 22, 2024

Retrying #10482 but with a resolution set for a newer version of rehackt instead of patching @apollo/client

This was the error we were getting. With the new rehackt release it's now gone.

image

ERROR in ../node_modules/@apollo/client/react/hooks/internal/useRenderGuard.js 4:23-79
export '__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED' (imported as 'React') was not found in 'rehackt' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE, act, cache, cloneElement, createContext, createElement, createRef, forwardRef, isValidElement, lazy, memo, startTransition, unstable_useCacheRefresh, use, useActionState, useCallback, useContext, useDebugValue, useDeferredValue, useEffect, useId, useImperativeHandle, useInsertionEffect, useLayoutEffect, useMemo, useOptimistic, useReducer, useRef, useState, useSyncExternalStore, useTransition, version)
 @ ../node_modules/@apollo/client/react/hooks/internal/index.js 4:0-53 4:0-53
 @ ../node_modules/@apollo/client/react/hooks/useQuery.js 13:0-47 51:11-19
 @ ../node_modules/@apollo/client/react/hooks/index.js 5:0-41 5:0-41
 @ ../node_modules/@apollo/client/react/index.js 3:0-33 3:0-33
 @ ../node_modules/@apollo/client/index.js 2:0-33 2:0-33
 @ ../node_modules/@redwoodjs/web/dist/components/cell/createSuspendingCell.js
 @ ../node_modules/@redwoodjs/web/dist/components/cell/createCell.js 15:28-64
 @ ../node_modules/@redwoodjs/web/dist/index.js 136:18-60
 @ ./src/App.tsx 1:0-69 11:27-45 13:32-47
 @ ../node_modules/@redwoodjs/web/dist/entry/index.js

webpack 5.91.0 compiled with 1 error in 12512 ms
    at makeError (/home/runner/work/redwood/test-project/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/home/runner/work/redwood/test-project/node_modules/execa/index.js:118:26)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async _Task.task [as taskFn] (/home/runner/work/redwood/test-project/node_modules/@redwoodjs/cli/dist/commands/buildHandler.js:145:11)
    at async _Task.run (/home/runner/work/redwood/test-project/node_modules/listr2/dist/index.cjs:2049:11)

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Apr 22, 2024
@Tobbe Tobbe added this to the RSC milestone Apr 22, 2024
@Tobbe Tobbe merged commit 859d93b into redwoodjs:main Apr 22, 2024
46 checks passed
@Tobbe Tobbe deleted the tobbe-retry-react-19-upgrade branch April 22, 2024 14:01
dac09 added a commit that referenced this pull request Apr 22, 2024
…g-gen-mw-p2

* 'main' of github.com:redwoodjs/redwood:
  fix(deps): update React to latest canary 19.x (#10496)
  fix(upgrade): Download yarn patches (#10497)
  Revert React 19 upgrade (#10482 and #10491) (#10495)
  Modified type for describeScenario (#10468)
  fix(upgrade): Download yarn patches (#10491)
  fix(deps): update React to latest canary 19.x (#10482)
  chore(dataMigrate): Fix package.json directory value (#10490)
  RSC: css preinit: Add required option precedence (#10481)
  chore(renovate): Remove config for unused package (#10489)
  RSC: Update test projects to use new @apollo/client-react-streaming (#10488)
  RSC: Remove unused vite patch from test-project-rsa (#10487)
  chore(ssr): Switch to use `@apollo/client-react-streaming` package (#10484)
  chore(docs): Move .mdx import into separate file (#10486)
  fix(cli): avoid `npx` during upgrade command (#10479)
  fix: Fixes Unknown Fragment issues due to GraphQL Tag type mismatch in web (#10357)
  RSC: Clean up some comments and logs (#10480)
  feat: redwoodjs/auth-dbauth-middleware - Part 2/3 - Auth Middleware for dbAuth to authenticate users via cookie (#10447)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants