-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/supabase version 1 #1474
fix/supabase version 1 #1474
Conversation
duncanhealy
commented
Nov 13, 2020
- fix methods used by supabase 1.0 Upgrade Supabase in auth package to supabase-js version 1.0 #1426
- update supabase package to 1.0 Upgrade Supabase in auth package to supabase-js version 1.0 #1426
@Tobbe and I realized tonight that perhaps something changed in the Supabase API that may now require a custom decoder to extract the see:
It is "spreading" the JWT into chars -- and not sure if it did that in the past. This might mean that supabase should get its own decoder similar to what is done for Netlify Identity: https://github.com/redwoodjs/redwood/blob/main/packages/api/src/auth/decoders/netlify.ts where is
so that Note: this does not verify the accessToken, though it probably should ... to check for expiry against the secret --- which would be then a required env. |
…a-schema-path Use original prisma schema path.
Fix schema paths
…otes Fixes DB Generators failing when a schema path includes spaces or other problematic characters
…th-spaces Fix redwoodjs#1278 launch Storybook with path w/ spaces
Allow users to "bring your own" GraphQL Library
…arn/nodemon-2.0.6 Bump nodemon from 2.0.5 to 2.0.6
…no-auth Fix FetchConfigProvider to reprise handling no auth
…ld-command Add --build option to `yarn rw storybook`
update diagnostics to display success message when no errors or warnings are encountered
thanks for the tag @viperfx. I just released the new version of gotrue-js to include @duncanhealy's commit , then bumped the version in supabase-js.
Let me know if that's all you need here, otherwise I can jump in and figure out the types. I did actually start on this but I'm swamped with our beta launch - thanks the patience 🙏 |
…od into fix/supabase_version_1
…od into fix/supabase_version_1
Thanks @kiwicopple Look forward to these changes @duncanhealy Let me know if you need help testing. |
I'm getting null back for the user object from the graphql endpoint after logging in {"data":{"redwood":{"currentUser":{"0":"n","1":"u","2":"l","3":"l","roles":[]}}}} looking at local dev -> might be because of this
changing with that change I get back - {"data":{"redwood":{"currentUser":{"roles":[]}}}} |
Hi @duncanhealy you may need to implement a decoder for supabase. I do not think using the netlify decoder is 100% correct, because it relies on the Identity feature of Netlify to place a decoded and populated user in the context in production --- and that the token is decoded in in dev. What is supabase setting as the token in
? Based on that will need to determine how the decode it if needed. |
@duncanhealy Thanks for getting the ball rolling on this! Your work both here and over in the supabase repo(s) is much appreciated ⭐ I went ahead and upgraded to Supabase 1.0 over here #1536 and that PR has now been merged. |
@kiwicopple I did the upgrade from scratch over in #1536 and so I wanted to ask if you could please take a look at the type imports. More details over in that PR. |