-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): add 3D OSM building tiles #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
=======================================
Coverage 35.72% 35.72%
=======================================
Files 339 339
Lines 30202 30202
=======================================
Hits 10789 10789
Misses 18369 18369
Partials 1044 1044 |
rot1024
requested changes
Sep 13, 2022
rot1024
requested changes
Sep 13, 2022
rot1024
changed the title
feat: add 3D OSM building tiles
feat(server): add 3D OSM building tiles
Sep 13, 2022
Co-authored-by: rot1024 <aayhrot@gmail.com>
KaWaite
reviewed
Sep 14, 2022
Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
KaWaite
approved these changes
Sep 14, 2022
rot1024
approved these changes
Sep 14, 2022
HideBa
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
OSM Buildings is a 3D buildings layer covering the entire world. It's available as a 3D Tileset on Cesium.
we modified reearth back end in way that allows the user to add OSM building 3d Tileset as a layer in his project by providing him with an interface to chose which tiles to show on the map.
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo
Design
https://www.figma.com/file/bdnfDaGXGoNfUws4y7JItl/Re%3AEarth-UI-Gamma?node-id=11576%3A179143