This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
feat: add 3D OSM building tiles #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 17.07% 17.07% -0.01%
==========================================
Files 502 502
Lines 49273 49284 +11
Branches 550 550
==========================================
+ Hits 8415 8416 +1
- Misses 40840 40850 +10
Partials 18 18
|
added 3 commits
September 13, 2022 12:21
KaWaite
reviewed
Sep 14, 2022
src/components/molecules/Visualizer/Engine/Cesium/Tileset/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Sep 14, 2022
KaWaite
reviewed
Sep 14, 2022
src/components/molecules/Visualizer/Engine/Cesium/Tileset/index.tsx
Outdated
Show resolved
Hide resolved
…x.tsx Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
…x.tsx Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
KaWaite
reviewed
Sep 14, 2022
src/components/molecules/Visualizer/Engine/Cesium/Tileset/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Sep 14, 2022
src/components/molecules/Visualizer/Engine/Cesium/Tileset/index.tsx
Outdated
Show resolved
Hide resolved
…x.tsx Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
…x.tsx Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
KaWaite
approved these changes
Sep 14, 2022
rot1024
approved these changes
Sep 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
OSM Buildings is a 3D buildings layer covering the entire world. It's available as a 3D Tileset on Cesium.
we modified reearth in way that allows the user to add OSM building 3d Tileset as a layer.
What I've done
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
Memo
backend pr : reearth/reearth-visualizer#340