Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Var passed to rx.toast #4405

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Handle Var passed to rx.toast #4405

merged 4 commits into from
Nov 22, 2024

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Nov 20, 2024

If the user provides a Var for message then apply it as props["title"] to avoid a var operations error.

If the user provides a `Var` for `message` then apply it as `props["title"]` to
avoid a var operations error.
Lendemor
Lendemor previously approved these changes Nov 21, 2024
Lendemor
Lendemor previously approved these changes Nov 21, 2024
Copy link
Collaborator Author

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 @adhami3310 plz approve for merge

@adhami3310 adhami3310 merged commit bbfbc82 into main Nov 22, 2024
32 checks passed
@adhami3310 adhami3310 deleted the masenf/toasty-var-🍞 branch November 22, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants