Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Var passed to rx.toast #4405

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Handle Var passed to rx.toast #4405

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85a9cef
Handle Var passed to `rx.toast`
masenf Nov 20, 2024
0cf2605
remove unnecessary parentheses
masenf Nov 20, 2024
0319f3d
remove weird hacks
adhami3310 Nov 21, 2024
eb59d54
get it right pyright
adhami3310 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion reflex/components/sonner/toast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,9 @@ def send_toast(message: str = "", level: str | None = None, **props) -> EventSpe
"Toaster component must be created before sending a toast. (use `rx.toast.provider()`)"
)
toast_command = f"{toast_ref}.{level}" if level is not None else toast_ref
if message == "" and ("title" not in props or "description" not in props):
if isinstance(message, Var):
props.setdefault("title", message)
elif message == "" and "title" not in props and "description" not in props:
raise ValueError("Toast message or title or description must be provided.")
if props:
args = LiteralVar.create(ToastProps(component_name="rx.toast", **props)) # type: ignore
Expand Down
Loading