Use https scheme and appassets.androidplatform.net instead of file:// for android. #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for android. This follows the usage recommended at https://developer.android.com/reference/androidx/webkit/WebViewAssetLoader to avoid an issue where assets referred to by file:// urls would receive a permissions error and never be passed to shouldInterceptRequest in sufficiently high API levels. It may be appropriate to expose a method to use a different base URI, which could simplify CORS for android apps in some use cases, and additionally a full conversion to WebViewAssetLoader might be reasonable.
jonored
force-pushed
the
jg/android-webview-asset-permissions-update
branch
from
cff4412
to
396da6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the usage recommended at
https://developer.android.com/reference/androidx/webkit/WebViewAssetLoader to avoid an issue where assets referred to by file:// urls would receive a permissions error and never be passed to shouldInterceptRequest in sufficiently high API levels.
It may be appropriate to expose a method to use a different base URI, which could simplify CORS for android apps in some use cases, and additionally a full conversion to WebViewAssetLoader might be reasonable.