-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge v0.46.7-regen-2 into release/v0.46.10-regen #52
chore: merge v0.46.7-regen-2 into release/v0.46.10-regen #52
Conversation
* fix!(group): Register types with Amino * Chagenlog
* fix!: Fix gov amino codec * changelog
* fix!: Fix group amino codec * changelog
…ork/cosmos-sdk into ryan/add-amino-fixes
…mos#14305) (cosmos#14309) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
* Make extension snapshotter interface safer to use Closes: cosmos#11824 Solution: - Use new methods `SnapshotExtension`/`RestoreExtension` to handle payload stream specifically. - Improve unit tests. * update changelog * Update snapshots/types/util.go * changelog * go linter * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
fix: gov and group amino and snapshot hashes
feat(gov): support v1.Proposal in v1beta1.Proposal.Content
Cosmos SDK v0.46.7 Regen-2
Why is this diff so large? Were there really that many changes that we made to v0.46.7 ? I remember stuff w/ Amino, upgrading to require go 1.19, and some other things that we back ported in from v0.47. But surprised that it covers so many files. |
Yup, these are the same changes (and a few less due to their inclusion in the latest) that we made in #49 |
The changes made in #51 were included in the latest on the sdk side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through all the commits in this PR and verified that we have everything that was in release/v0.46.7-regen
branch (additional to the official v0.46.7 release).
lgtm!
Lint PR is failing due to conventional commit check failing on PR title, maybe update that before merging? |
Description
This pull request merges the
v0.46.7-regen-2
release into the newv0.46.10
release branch (created fromv0.46.10
).Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change