Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge v0.46.7-regen-2 into release/v0.46.10-regen #52

Merged
merged 13 commits into from
Feb 23, 2023

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Feb 22, 2023

Description

This pull request merges the v0.46.7-regen-2 release into the new v0.46.10 release branch (created from v0.46.10).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

ryanchristo and others added 13 commits December 12, 2022 11:23
* fix!(group): Register types with Amino

* Chagenlog
* fix!: Fix gov amino codec

* changelog
* fix!: Fix group amino codec

* changelog
…mos#14305) (cosmos#14309)

Co-authored-by: Daniel Wedul <github@wedul.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
* Make extension snapshotter interface safer to use

Closes: cosmos#11824
Solution:
- Use new methods `SnapshotExtension`/`RestoreExtension` to handle payload stream specifically.
- Improve unit tests.

* update changelog

* Update snapshots/types/util.go

* changelog

* go linter

* Update CHANGELOG.md

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
fix: gov and group amino and snapshot hashes
feat(gov): support v1.Proposal in v1beta1.Proposal.Content
@clevinson
Copy link
Member

Why is this diff so large? Were there really that many changes that we made to v0.46.7 ?

I remember stuff w/ Amino, upgrading to require go 1.19, and some other things that we back ported in from v0.47. But surprised that it covers so many files.

@ryanchristo
Copy link
Member Author

ryanchristo commented Feb 22, 2023

Why is this diff so large? Were there really that many changes that we made to v0.46.7 ?

Yup, these are the same changes (and a few less due to their inclusion in the latest) that we made in #49

@ryanchristo
Copy link
Member Author

The changes made in #51 were included in the latest on the sdk side.

Copy link
Member

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through all the commits in this PR and verified that we have everything that was in release/v0.46.7-regen branch (additional to the official v0.46.7 release).

lgtm!

@clevinson
Copy link
Member

Lint PR is failing due to conventional commit check failing on PR title, maybe update that before merging?

@ryanchristo ryanchristo changed the title Merge v0.46.7-regen-2 into v0.46.10-regen release branch chore: merge v0.46.7-regen-2 into v0.46.10-regen release branch Feb 23, 2023
@ryanchristo ryanchristo changed the title chore: merge v0.46.7-regen-2 into v0.46.10-regen release branch chore: merge v0.46.7-regen-2 into release/v0.46.10-regen Feb 23, 2023
@ryanchristo ryanchristo merged commit 3331263 into release/v0.46.10-regen Feb 23, 2023
@ryanchristo ryanchristo deleted the ryan/v0.46.10-regen-fixes branch February 23, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment