Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retirement reason and include in retire event #1624

Closed
4 tasks
Tracked by #972
ryanchristo opened this issue Nov 21, 2022 · 1 comment · Fixed by #1625
Closed
4 tasks
Tracked by #972

Add retirement reason and include in retire event #1624

ryanchristo opened this issue Nov 21, 2022 · 1 comment · Fixed by #1625
Assignees
Labels
Type: Feature New feature or request

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Nov 21, 2022

Summary

In the current implementation, we have a reason field for MsgCancel that is not stored in state but included in EventCancel but we do not have a reason field for MsgRetire.

In the past, we have used the transaction memo field for retirement reason but we should create a reason field for MsgRetire that is not stored in state but included in EventRetire (same as MsgCancel/EventCancel).

Problem Definition

Users must use the memo field of a transaction to provide a retirement reason but may want to use the memo field for something else or would rather use an explicit field for retirement reason.

Proposal

Add reason to MsgRetire that is not stored in state but included in EventRetire.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ryanchristo ryanchristo added the Type: Feature New feature or request label Nov 21, 2022
@ryanchristo
Copy link
Member Author

A reason field would also need to be added to MsgCreateBatch and MsgSend in the ecocredit module and MsgBuyDirect within the marketplace submodule and MsgTake within the basket submodule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant