Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): add retirement reason #1625

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Conversation

ryanchristo
Copy link
Member

Description

Closes: #1624

Add reason to all messages that can trigger retirement and update tests to include check for reason.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #1625 (a317ef5) into main (dccf079) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head a317ef5 differs from pull request most recent head f1f6cfe. Consider uploading reports for the commit f1f6cfe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1625      +/-   ##
==========================================
- Coverage   77.59%   77.51%   -0.09%     
==========================================
  Files         266      264       -2     
  Lines       19457    19321     -136     
==========================================
- Hits        15098    14977     -121     
+ Misses       3490     3479      -11     
+ Partials      869      865       -4     
Impacted Files Coverage Δ
x/ecocredit/base/keeper/msg_create_batch.go 66.49% <100.00%> (+0.17%) ⬆️
x/ecocredit/base/keeper/msg_retire.go 59.75% <100.00%> (+0.49%) ⬆️
x/ecocredit/base/keeper/msg_send.go 69.40% <100.00%> (+0.23%) ⬆️
x/ecocredit/base/types/v1/msg_retire.go 92.00% <100.00%> (+1.09%) ⬆️
x/ecocredit/base/types/v1/msg_send.go 95.12% <100.00%> (+0.38%) ⬆️
x/ecocredit/base/types/v1/types_batch_issuance.go 100.00% <100.00%> (ø)
x/ecocredit/basket/keeper/msg_take.go 59.77% <100.00%> (+0.68%) ⬆️
x/ecocredit/basket/types/v1/msg_take.go 87.80% <100.00%> (+0.96%) ⬆️
x/ecocredit/marketplace/keeper/msg_buy_direct.go 76.13% <100.00%> (+0.27%) ⬆️
x/ecocredit/marketplace/keeper/utils.go 42.85% <100.00%> (+0.45%) ⬆️
... and 8 more

@ryanchristo ryanchristo marked this pull request as ready for review November 22, 2022 00:27
@ryanchristo ryanchristo requested a review from a team November 22, 2022 00:27
Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
in which release will this be included?

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo
Copy link
Member Author

in which release will this be included?

This will be included in v5.0 (only the bridge event update will be included in v4.1.5).

@ryanchristo
Copy link
Member Author

It's optional so the tx memo field can still be used and interface team can update when ready.

@ryanchristo ryanchristo merged commit 116e9fa into main Nov 22, 2022
@ryanchristo ryanchristo deleted the ryan/1624-retire-reason branch November 22, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add retirement reason and include in retire event
3 participants