-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/ecocredit): add retirement reason #1625
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1625 +/- ##
==========================================
- Coverage 77.59% 77.51% -0.09%
==========================================
Files 266 264 -2
Lines 19457 19321 -136
==========================================
- Hits 15098 14977 -121
+ Misses 3490 3479 -11
+ Partials 869 865 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
in which release will this be included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This will be included in v5.0 (only the bridge event update will be included in v4.1.5). |
It's optional so the tx memo field can still be used and interface team can update when ready. |
Description
Closes: #1624
Add
reason
to all messages that can trigger retirement and update tests to include check for reason.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change