Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use retirement reason instead of tx memo #1502

Closed
3 tasks done
blushi opened this issue Jan 11, 2023 · 3 comments · Fixed by regen-network/regen-web#1822
Closed
3 tasks done

Use retirement reason instead of tx memo #1502

blushi opened this issue Jan 11, 2023 · 3 comments · Fixed by regen-network/regen-web#1822
Assignees
Labels
dev Engineering tasks

Comments

@blushi
Copy link
Member

blushi commented Jan 11, 2023

Is your feature request related to a problem? Please describe.
As part of regen-ledger v5.0 release, retirement reason has been added (regen-network/regen-ledger#1624). Previously we were using the tx memo/note to record this info.

Describe the solution you'd like
Use retirement reason instead of tx memo in CreditsRetireForm
MsgTake and MsgBuyDirect are also impacted.

See design with updated copy for field label/description: https://www.figma.com/file/seUiQM2SPt78KJiDL0Ea8m/Basic-Ecocredits-Ledger-View-%2F-Marketplace?node-id=5539%3A147414&t=F5MCf0DQelKJR9jS-1

We also need to update the proto types in regen-js so the impacted types include this new field, tag/deploy a new release and use it in web-registry cc/ @haveanicedavid

Additional context (optional)
See migration guide: https://github.com/regen-network/regen-ledger/blob/main/docs/ledger/migrations/v5.0-migration.md


For Admin Use

  • Not duplicate issue
  • Appropriate labels and zenhub epics applied
  • Appropriate contributors tagged
@blushi blushi added the dev Engineering tasks label Jan 11, 2023
@blushi
Copy link
Member Author

blushi commented Jan 16, 2023

Please add your planning poker estimate with Zenhub @flagrede

@blushi
Copy link
Member Author

blushi commented Jan 16, 2023

Please add your planning poker estimate with Zenhub @haveanicedavid

@blushi
Copy link
Member Author

blushi commented Jan 19, 2023

Updating the point estimate here after discussing this with @haveanicedavid since we're gonna need to make some updates to regen-js (see description)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Engineering tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants