Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update proto files for regen-ledger v5.0 and cosmos-sdk v0.46.7 #66

Merged
merged 6 commits into from
Mar 27, 2023

Conversation

blushi
Copy link
Member

@blushi blushi commented Mar 2, 2023

ref: regen-network/rnd-dev-team#1502

Note for reviewing: no need to look at all the changes in .proto and corresponding generated TS files, I guess the amino converter files are the most important to review and most importantly to test it's working (did it for most of the messages manually and made sure it's covered in our e2e tests too)

It was definitely more tedious than expected:

@blushi blushi requested a review from a team March 2, 2023 17:08
Copy link

@haveanicedavid haveanicedavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are build errors but IIRC these are expected (?) so i’m approving

@blushi
Copy link
Member Author

blushi commented Mar 6, 2023

I need to update the amino types as well!

@blushi blushi force-pushed the feat-proto-upgrade-regenv5 branch from dc7009a to 08a526a Compare March 7, 2023 12:23
@blushi
Copy link
Member Author

blushi commented Mar 7, 2023

Some amino tests are failing for core ecocredits so still need to investigate this
I believe I had missed updating my api build locally, which was causing errors, now working

@@ -95,7 +95,7 @@ xdescribe('RegenApi with tendermint connection - Amino Tests', () => {

const TEST_MSG_SEND = MsgSend.fromPartial({
sender: TEST_ADDRESS,
recipient: TEST_ADDRESS,
recipient: TEST_BUYER_ADDRESS,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is because regen-ledger v5.0 doesn't allow sending credits to oneself regen-network/regen-ledger#1674

@blushi blushi requested a review from a team March 8, 2023 15:59
Copy link
Contributor

@flagrede flagrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good!
Will try to do some testing later.

@haveanicedavid
Copy link

@blushi I tested this locally through symlinking to regen-web and trying several relevant actions, but wasn’t able to test amino changes due to not having a ledger with me

@blushi
Copy link
Member Author

blushi commented Mar 20, 2023

@haveanicedavid @flagrede could you test this further?
It seems like you did @haveanicedavid given your work in regen-network/regen-web#1822
are we ok to merge this then and tag/publish a new release?

@blushi
Copy link
Member Author

blushi commented Mar 20, 2023

@blushi I tested this locally through symlinking to regen-web and trying several relevant actions, but wasn’t able to test amino changes due to not having a ledger with me

thanks @haveanicedavid
FYI you can force amino signing using getOfflineSignerOnlyAmino instead of getOfflineSignerAuto as done in https://github.com/regen-network/regen-web/pull/1628/files

@blushi blushi merged commit 5feaeed into main Mar 27, 2023
@blushi blushi deleted the feat-proto-upgrade-regenv5 branch March 27, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants