-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use retirement reason instead of TX memo #1822
Conversation
…retire, sell order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the same changes in useCreditSendSubmit
and useCreateBatchSubmit
as well
@haveanicedavid I've just published 0.6.0 for https://www.npmjs.com/package/@regen-network/api?activeTab=readme so you can use it here |
…SendSubmit & useCreateBatchSubmit
tACK - i tested buy w/ retire from a project and the storefront, send w/ retire, retire from my portfolio and retire w/ take from basket. LGTM! i could see the retirement_reason in the tx's, i.e.: i was unsure what to test re. changes in, LMK if you'd like me to test something
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
We have a batch creation form at /ecocredits/create-batch but not sure if that's fully functional yet so ok to skip this I guess |
@erikalogie you can test this on https://deploy-preview-1822--regen-registry.netlify.app/ (from buy, send, retire...) |
@blushi this looks good to me! |
Description
Closes: regen-network/rnd-dev-team#1502
NOTE: regen-network/regen-js#66 will neeed to be merged before this, or you’ll need to pull down that work locally and symlink to properly test - the build will also fail until then. I also was unable to test with a ledger, so am uncertain about amino messagesI’m not super familiar with the code related to most of our marketplace functionality, but believe this should include all of the relevant areas
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
(if regen-network/regen-js#66 has’t been merged):
regen-js
, pull down the branch from feat: update proto files for regen-ledger v5.0 and cosmos-sdk v0.46.7 regen-js#66 (feat-proto-upgrade-regenv5
) & buildregen-web
setupReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have…