-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/ecocredit): update batch metadata #1623
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1623 +/- ##
==========================================
+ Coverage 77.48% 77.59% +0.10%
==========================================
Files 264 266 +2
Lines 19298 19457 +159
==========================================
+ Hits 14954 15098 +144
- Misses 3479 3490 +11
- Partials 865 869 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
return sdkerrors.ErrInvalidRequest.Wrapf("batch denom: %s", err) | ||
} | ||
|
||
// we allow removing metadata for class and project but not for batch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to this task but it seems like we can create a batch initially without any metadata (see MsgCreateBatch
.ValidateBasic()
) should this be fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. My thinking is we allow for class and project because they can be updated for batch it is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll open a followup since this has already been approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Closes: #1582
This pull request adds
UpdateBatchMetadata
, which can only be called by theissuer
on anopen
batch.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change