Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): require metadata for create batch #1630

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

ryanchristo
Copy link
Member

Description

Ref: #1623 (comment)

Credit batch metadata cannot be updated if the batch is sealed. This pull request ensures credit batch metadata is included when creating a new credit batch (class and project metadata is still optional - they can be updated).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo marked this pull request as ready for review November 22, 2022 20:30
@ryanchristo ryanchristo requested a review from a team November 22, 2022 20:30
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@e4fb4af). Click here to learn what that means.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1630   +/-   ##
=======================================
  Coverage        ?   77.62%           
=======================================
  Files           ?      266           
  Lines           ?    19484           
  Branches        ?        0           
=======================================
  Hits            ?    15125           
  Misses          ?     3490           
  Partials        ?      869           
Impacted Files Coverage Δ
x/ecocredit/base/types/v1/msg_create_batch.go 95.12% <100.00%> (ø)

@ryanchristo ryanchristo merged commit 6043274 into main Nov 23, 2022
@ryanchristo ryanchristo deleted the ryan/1623-batch-metadata-required branch November 23, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants