Changed fisher_data path and rm command

[jsmitley]

Moved fisher_data path from .config to .local/share to match latest fisher release
Changed rm to command rm so it doesn't try to use a fish rm function

[reitzig]

We should probably use XDG variables like fisher. 🤔

Will look at this when I next touch the project. Won't be tomorrow, sorry. Thanks for the ping!

[jsmitley]

Good point, I made that change now. Please look when you have a chance. Thanks!

[reitzig]

Can you please explain which problem this change solves? 🤔

[jsmitley]

Sorry I'm late with this! I have a separate command in my config that overrides rm (calls trash instead), which breaks this call. If I use the command to call rm, it ensures that any overrides for that command are disregarded and it seems to get the same desired result.

[jsmitley]

@reitzig Any thoughts on this? I don't know of a more fish-y way to handle this particular command override 🤷

[reitzig]

I don't think it's feasible to look out for overrides of "basic" commands. :/ See also #23.

I would basically have to prefix all tool calls with command -- and inevitably break some setup somewhere by doing that anyway.

FWIW, this is one reason why I hate writing shell scripts instead of "real" programs. In this instance, it can't be helped.

[rmartine-ias]

Changing rm to command rm also fixes the issue I'm having, where I aliased rm to rm -i. Was seeing something like this every time I ran sdk help:

rm: remove regular file '/var/folders/ht/q8z65bc15mx7gfzx5t3s7_mr0000gq/T/tmp.jFun2SabOO'?

[reitzig]

Sorry for the long silence.

Moved fisher_data path from .config to .local/share to match latest fisher release

Somehow, only a README change is left on this PR. I can't seem to remember what this part was about. Is there still an issue?

Ah, got it. This is about the line that sets __fish_sdkman_noexport_init. The path I hard-coded there was based on where fisher 3 installed plugin sources; fisher 4 uses the config dir of fish directly, unless overridden. We now use their code to determine where to put the auxiliary script. Thanks for the pointer, even though I didn't end put merging your PR! 🙏