Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete forcefully temp file for bashDump #42

Closed
wants to merge 1 commit into from

Conversation

liuml07
Copy link

@liuml07 liuml07 commented Jun 20, 2023

If the user sets alias alias rm "rm -i" to be protective about delete files, it will prompt every time we run sdk command. It's better to just forcefully delete the temp file.

Screenshot 2023-06-20 at 3 39 20 PM

If the user sets alias `alias rm "rm -i"` to be protective about delete files, it will prompt every time we run `sdk` command. It's better to just forcefully delete the temp file.
@reitzig
Copy link
Owner

reitzig commented Jun 25, 2023

It's not feasible to account for all ways users may think to override any of the "basic" commands in use; see also #23. I recommend to not do that.

FWIW, the fix put forth in #37 -- using command -- seems more appropriate.

@reitzig reitzig closed this Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants