Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluation result list page #105

Merged
merged 11 commits into from
Jul 31, 2019
Merged

Conversation

yuki-mt
Copy link
Member

@yuki-mt yuki-mt commented May 24, 2019

I will remove WIP after #103 is merged

What is this PR for?

add page for EvaluationResult list

This PR includes

frontend

  • add link to SideMenu
  • show EvaluationResult list
  • add Evaluate model button
  • able to delete EvaluationResult with checkbox

backend

  • add API to return list of EvalualtionResult

What type of PR is it?

Feature

What is the issue?

#23

How should this be tested?

python -m unittest test/apis/test_api_evaluation.py

@yuki-mt yuki-mt requested a review from keigohtr May 24, 2019 06:40
@yuki-mt yuki-mt self-assigned this May 24, 2019
@codecov-io
Copy link

codecov-io commented May 24, 2019

Codecov Report

Merging #105 into master will increase coverage by 38.98%.
The diff coverage is 29.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #105       +/-   ##
===========================================
+ Coverage   43.96%   82.95%   +38.98%     
===========================================
  Files          43       43               
  Lines        2311     2317        +6     
===========================================
+ Hits         1016     1922      +906     
+ Misses       1295      395      -900
Impacted Files Coverage Δ
rekcurd_dashboard/core/rekcurd_dashboard_client.py 70.47% <ø> (+15.75%) ⬆️
rekcurd_dashboard/apis/api_evaluation.py 38.65% <29.41%> (+4.67%) ⬆️
rekcurd_dashboard/apis/common.py 100% <0%> (+5.26%) ⬆️
...ekcurd_dashboard/utils/rekcurd_dashboard_config.py 81.39% <0%> (+5.81%) ⬆️
rekcurd_dashboard/models/evaluation_result.py 82.14% <0%> (+10.71%) ⬆️
rekcurd_dashboard/apis/api_admin.py 49.12% <0%> (+14.91%) ⬆️
rekcurd_dashboard/apis/__init__.py 91.93% <0%> (+17.74%) ⬆️
rekcurd_dashboard/models/data_server.py 93.18% <0%> (+18.18%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 616bada...0198ed8. Read the comment docs.

@yuki-mt yuki-mt force-pushed the feature/evaluation-result-list-page branch from 8ce193e to 27998e2 Compare May 24, 2019 07:31
@yuki-mt yuki-mt force-pushed the feature/evaluation-result-list-page branch from 7c0b12b to 0198ed8 Compare July 7, 2019 04:58
@yuki-mt yuki-mt changed the title [WIP] evaluation result list page evaluation result list page Jul 7, 2019
@CLAassistant
Copy link

CLAassistant commented Jul 8, 2019

CLA assistant check
All committers have signed the CLA.

@yuki-mt yuki-mt force-pushed the feature/evaluation-result-list-page branch from 5decf16 to 1638c99 Compare July 8, 2019 03:54
@yuki-mt
Copy link
Member Author

yuki-mt commented Jul 8, 2019

I merged test fix from #109 . please review it now @keigohtr

Copy link
Member

@keigohtr keigohtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made a great work!
I have made few comments. Could you check them?

rekcurd_dashboard/apis/api_evaluation.py Outdated Show resolved Hide resolved
rekcurd_dashboard/apis/api_evaluation.py Show resolved Hide resolved
rekcurd_dashboard/apis/api_evaluation.py Show resolved Hide resolved
@yuki-mt yuki-mt force-pushed the feature/evaluation-result-list-page branch from 4a0f7a9 to 2f513e4 Compare July 13, 2019 08:22
Copy link
Member

@keigohtr keigohtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuki-mt Thank you for your great work!

I found that all files after evaluation have Invalid Date on Registered Date.
Could you check it?

@yuki-mt
Copy link
Member Author

yuki-mt commented Jul 27, 2019

@keigohtr I just fixed the Invalid Date in EvaluationResult!

Copy link
Member

@keigohtr keigohtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuki-mt yuki-mt merged commit 5802a41 into master Jul 31, 2019
@yuki-mt yuki-mt deleted the feature/evaluation-result-list-page branch July 31, 2019 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants