-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evaluation result list page #105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
===========================================
+ Coverage 43.96% 82.95% +38.98%
===========================================
Files 43 43
Lines 2311 2317 +6
===========================================
+ Hits 1016 1922 +906
+ Misses 1295 395 -900
Continue to review full report at Codecov.
|
8ce193e
to
27998e2
Compare
7c0b12b
to
0198ed8
Compare
5decf16
to
1638c99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You made a great work!
I have made few comments. Could you check them?
4a0f7a9
to
2f513e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuki-mt Thank you for your great work!
I found that all files after evaluation have Invalid Date
on Registered Date
.
Could you check it?
@keigohtr I just fixed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I will remove WIP after #103 is merged
What is this PR for?
add page for EvaluationResult list
This PR includes
frontend
Evaluate model
buttonbackend
What type of PR is it?
Feature
What is the issue?
#23
How should this be tested?
python -m unittest test/apis/test_api_evaluation.py