Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicated_ok #109

Merged
merged 2 commits into from
Jul 8, 2019
Merged

remove duplicated_ok #109

merged 2 commits into from
Jul 8, 2019

Conversation

yuki-mt
Copy link
Member

@yuki-mt yuki-mt commented Jul 7, 2019

What is this PR for?

remove duplicated_ok because I forgot doing so in #103

This PR includes

  • item
  • item
  • item

What type of PR is it?

fix

What is the issue?

N/A

How should this be tested?

python -m unittest test/apis/test_api_evaluation.py

@yuki-mt yuki-mt requested a review from keigohtr July 7, 2019 05:20
@yuki-mt yuki-mt self-assigned this Jul 7, 2019
@codecov-io
Copy link

codecov-io commented Jul 7, 2019

Codecov Report

Merging #109 into master will increase coverage by 39.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #109       +/-   ##
===========================================
+ Coverage   43.96%   83.24%   +39.28%     
===========================================
  Files          43       43               
  Lines        2311     2310        -1     
===========================================
+ Hits         1016     1923      +907     
+ Misses       1295      387      -908
Impacted Files Coverage Δ
rekcurd_dashboard/apis/api_evaluation.py 40.64% <ø> (+6.67%) ⬆️
rekcurd_dashboard/apis/common.py 100% <0%> (+5.26%) ⬆️
...ekcurd_dashboard/utils/rekcurd_dashboard_config.py 81.39% <0%> (+5.81%) ⬆️
rekcurd_dashboard/models/evaluation_result.py 82.14% <0%> (+10.71%) ⬆️
rekcurd_dashboard/apis/api_admin.py 49.12% <0%> (+14.91%) ⬆️
rekcurd_dashboard/core/rekcurd_dashboard_client.py 70.75% <0%> (+16.03%) ⬆️
rekcurd_dashboard/apis/__init__.py 91.93% <0%> (+17.74%) ⬆️
rekcurd_dashboard/models/data_server.py 93.18% <0%> (+18.18%) ⬆️
rekcurd_dashboard/apis/api_misc.py 100% <0%> (+25%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 616bada...16ab19f. Read the comment docs.

@yuki-mt yuki-mt force-pushed the feature/remove-duplicated-ok branch 3 times, most recently from 32c0fbf to 390ed15 Compare July 7, 2019 07:59
@yuki-mt yuki-mt force-pushed the feature/remove-duplicated-ok branch from 390ed15 to 16ab19f Compare July 7, 2019 08:57
@yuki-mt
Copy link
Member Author

yuki-mt commented Jul 7, 2019

Please review this PR first (fixed library versions in this PR) @keigohtr

@@ -8,7 +8,7 @@ PyYAML>=3.12 # MIT
SQLAlchemy>=1.2.7 # MIT
PyMySQL>=0.8.0 # MIT
flask-sqlalchemy>=2.3.2 # BSD
kubernetes>=v8.0.0 # Apache-2.0
kubernetes>=v8.0.0,<10.0.0 # Apache-2.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is from this issue: kubernetes-client/python#866

Copy link
Member

@keigohtr keigohtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuki-mt yuki-mt merged commit 15ae44e into master Jul 8, 2019
@yuki-mt yuki-mt deleted the feature/remove-duplicated-ok branch July 8, 2019 03:51
yuki-mt added a commit that referenced this pull request Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants