Use npm workspaces #822
Merged
Use npm workspaces #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
👋 phase/new
|
Test failure also happens on current |
ChristianMurphy
force-pushed
the
build/replace-lerna-with-workspaces
branch
from
0bc5981
to
73d0c10
Compare
ChristianMurphy
force-pushed
the
build/replace-lerna-with-workspaces
branch
from
73d0c10
to
5e3cd43
Compare
ChristianMurphy
commented
Aug 26, 2021
Comment on lines
+32
to
+37
| "workspaces": [ | ||
| "packages/remark-parse", | ||
| "packages/remark-stringify", | ||
| "packages/remark", | ||
| "packages/remark-cli" | ||
| ], |
There was a problem hiding this comment.
build order matters here, when specified as packages/* it goes out of order https://github.com/remarkjs/remark/runs/3433219485?check_suite_focus=true#step:6:16
This comment has been minimized.
This comment has been minimized.
wooorm
reviewed
Aug 26, 2021
| "packages/remark-parse", | ||
| "packages/remark-stringify", | ||
| "packages/remark", | ||
| "packages/remark-cli" |
There was a problem hiding this comment.
Oh so this fixes order?!
So that’s it! I had similar problems before: https://twitter.com/wooorm/status/1416491869488492546. PR to fix it linked from there: npm/arborist#303
wooorm
approved these changes
Aug 26, 2021
This comment has been minimized.
This comment has been minimized.
5 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Leverage npm's built in workspaces feature https://docs.npmjs.com/cli/v7/using-npm/workspaces to manage the monorepo.