feat(compiler): officially support Deno #3117

pcattori · 2022-05-06T20:38:36Z

Docs

I will update docs/ with mentions to @remix-run/deno as a follow-up PR targeting the main branch since there are changes there that we want to add to.

Testing Strategy

Integration test: deno-compiler-test.ts

Manually testing

Have to jump through a few hoops to get the locally built packages all plumbed through...

Build remix-run/remix:

yarn build

Package @remix-run/deno locally:

cd build/node_modules/@remix-run/deno
npm pack

Create a Remix app with the Deno template, without running npm install:

npx create-remix@latest --template <path/to/templates/deno>
# answer "n" (no) when prompted if `npm install` should be run

Install the locally packaged @remix-run/deno:

npm i <path/to/remix/build/node_modules/@remix-run/deno/package.tar.gz>

Use the local compiler to build, run, and dev

node <path/to/remix/build/node_modules/@remix-run/dev/cli.js> build
node <path/to/remix/build/node_modules/@remix-run/dev/cli.js> start

node <path/to/remix/build/node_modules/@remix-run/dev/cli.js> watch
# in another terminal window...
npm run dev:deno

MichaelDeBoey

This is awesome! 🔥

We'll probably also need magicExports, like we have for cloudflare & node runtimes?

packages/remix-dev/compiler/plugins/urlImportsPlugin.ts

templates/deno/package.json

packages/remix-deno/globals.ts

pcattori · 2022-05-09T20:40:29Z

We'll probably also need magicExports, like we have for cloudflare & node runtimes?

We don't need nor want magic exports for Deno since we don't have to support existing Deno projects that import {...} from "remix".

MichaelDeBoey · 2022-05-09T20:44:46Z

We don't need nor want magic exports for Deno since we don't have to support existing Deno projects that import {...} from "remix".

This would break our "just copy over your app directory to a new project with different adapter/runtime" promise though.

pcattori · 2022-05-09T22:12:12Z

We don't need nor want magic exports for Deno since we don't have to support existing Deno projects that import {...} from "remix".

This would break our "just copy over your app directory to a new project with different adapter/runtime" promise though.

We can't promise that. E.g. if someone writes Deno.readFile in their loader, that won't work on Node. A completely portable app/ folder would be ideal, but its not something we currently do.

MichaelDeBoey · 2022-05-09T22:45:58Z

We can't promise that. E.g. if someone writes Deno.readFile in their loader, that won't work on Node. A completely portable app/ folder would be ideal, but its not something we currently do.

Good point on that one.

If I recall correctly, thie "advice" @mjackson used to give for changing adapter/runtime has always been "create a new project with the required adapter/runtime & copy over your app folder" (I even thought it was somewhere in the docs, but can't find it), that's why I was thinking the magicExports would be needed

packages/remix-deno/package.json

docs/decisions/0001-use-npm-to-manage-npm-dependencies-for-deno-projects.md

integration/deno-compiler-test.ts

packages/remix-deno/server.ts

templates/deno/README.md

templates/deno/package.json

packages/remix-deno/server.ts

keep url imports as-is in build output so that each runtime can handle url imports in their own way. for example, deno will download dependencies from url imports at runtime. the browser will download dependendencies from url imports on-demand. node will simply throw an error when encountering a url import. since we will recommend to use npm/node_modules for dependency management (even for deno), the only url imports we expect are for deno imports on the server from https://deno.land or from Deno-friendly CDNs like https://esm.sh .

previously, `shell.grep` was being called with the `-r` option, which it does not recognize, resulting in an exit ode of 1. we incorrectly interpreted that as `grep` finishing the search without finding matches. instead, the `shell.grep` call was crashing. now we correctly pass a list of files to `shell.grep` without the `-r` option.

…ot found so that `createRequestHandlerWithStaticFiles` is more portable across runtimes and adapters

github-actions · 2022-05-17T19:12:57Z

🤖 Hello there,

We just published version v1.5.0-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions · 2022-05-18T20:05:55Z

🤖 Hello there,

We just published version v1.5.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

remix-cla-bot bot added the CLA Signed label May 6, 2022

pcattori force-pushed the pedro/deno branch 5 times, most recently from 8c59fae to 98d8696 Compare May 9, 2022 20:01

pcattori changed the title ~~Pedro/deno~~ Deno support May 9, 2022

pcattori changed the title ~~Deno support~~ feat(deno): officially support Deno May 9, 2022

pcattori force-pushed the pedro/deno branch 3 times, most recently from 5e84dc1 to 7d0425b Compare May 9, 2022 20:07

MichaelDeBoey added feat:deno Issues related to Deno support package:dev template:deno runtime:deno labels May 9, 2022

MichaelDeBoey requested changes May 9, 2022

View reviewed changes

packages/remix-dev/compiler/plugins/urlImportsPlugin.ts Show resolved Hide resolved

templates/deno/package.json Outdated Show resolved Hide resolved

packages/remix-deno/globals.ts Show resolved Hide resolved

pcattori force-pushed the pedro/deno branch from 7d0425b to a8899f0 Compare May 9, 2022 22:34

pcattori force-pushed the pedro/deno branch 8 times, most recently from 442d954 to d467eb5 Compare May 10, 2022 17:12

MichaelDeBoey requested changes May 10, 2022

View reviewed changes

packages/remix-deno/package.json Show resolved Hide resolved

docs/decisions/0001-use-npm-to-manage-npm-dependencies-for-deno-projects.md Outdated Show resolved Hide resolved

MichaelDeBoey requested changes May 11, 2022

View reviewed changes

integration/deno-compiler-test.ts Outdated Show resolved Hide resolved

integration/deno-compiler-test.ts Outdated Show resolved Hide resolved

integration/deno-compiler-test.ts Show resolved Hide resolved

pcattori force-pushed the pedro/deno branch from c933c08 to 6f98618 Compare May 11, 2022 19:34

MichaelDeBoey approved these changes May 11, 2022

View reviewed changes

pcattori commented May 11, 2022

View reviewed changes

integration/deno-compiler-test.ts Outdated Show resolved Hide resolved

mjackson requested changes May 11, 2022

View reviewed changes

integration/deno-compiler-test.ts Outdated Show resolved Hide resolved

packages/remix-deno/server.ts Show resolved Hide resolved

templates/deno/README.md Outdated Show resolved Hide resolved

templates/deno/package.json Outdated Show resolved Hide resolved

pcattori force-pushed the pedro/deno branch from 6f98618 to 9e3b2b9 Compare May 11, 2022 21:46

pcattori requested a review from mjackson May 11, 2022 22:20

mjackson requested changes May 13, 2022

View reviewed changes

packages/remix-deno/server.ts Outdated Show resolved Hide resolved

packages/remix-deno/server.ts Outdated Show resolved Hide resolved

packages/remix-deno/server.ts Outdated Show resolved Hide resolved

packages/remix-deno/server.ts Outdated Show resolved Hide resolved

MichaelDeBoey mentioned this pull request May 17, 2022

feat: add @remix-run/netlify-edge package + update Netlify template #3104

Closed

2 tasks

pcattori added 8 commits May 17, 2022 09:58

docs(decisions): use npm to manage NPM dependencies for Deno projects

e0c70df

feat(compiler): can build deno-compatible server bundle

a309ed7

feat(@remix-run/deno): add server runtime package for deno

1269bca

feat(templates/deno): use npm-managed dependencies

5aba5d4

test(compiler): browser and server bundles for deno

ba8bfb9

refactor(@remix-run/deno): throw custom error when static files are n…

1618391

…ot found so that `createRequestHandlerWithStaticFiles` is more portable across runtimes and adapters

pcattori force-pushed the pedro/deno branch from 9e4e995 to 1618391 Compare May 17, 2022 14:03

pcattori requested a review from mjackson May 17, 2022 14:04

mjackson approved these changes May 17, 2022

View reviewed changes

pcattori merged commit aa39050 into dev May 17, 2022

pcattori deleted the pedro/deno branch May 17, 2022 18:31

MichaelDeBoey mentioned this pull request May 19, 2022

chore(templates/deno): add missing typings to devDependencies #3256

Closed

donavon mentioned this pull request Jul 31, 2022

[Snyk] Security upgrade @remix-run/serve from 1.2.3 to 1.5.0 donavon/remix#17

Open

snyk-bot mentioned this pull request Aug 1, 2022

[Snyk] Security upgrade @remix-run/serve from 1.2.3 to 1.5.0 donavon/remix#19

Open

donavon mentioned this pull request Aug 1, 2022

[Snyk] Security upgrade @remix-run/serve from 1.2.3 to 1.5.0 donavon/remix#20

Open

This was referenced Nov 28, 2023

[Snyk] Security upgrade @remix-run/serve from 1.2.3 to 1.5.0 donavon/remix#34

Open

[Snyk] Security upgrade @remix-run/serve from 1.2.3 to 1.5.0 donavon/remix#36

Open

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(compiler): officially support Deno #3117

feat(compiler): officially support Deno #3117

pcattori commented May 6, 2022 •

edited

Loading

MichaelDeBoey left a comment •

edited

Loading

pcattori commented May 9, 2022

MichaelDeBoey commented May 9, 2022

pcattori commented May 9, 2022

MichaelDeBoey commented May 9, 2022

github-actions bot commented May 17, 2022

github-actions bot commented May 18, 2022

feat(compiler): officially support Deno #3117

feat(compiler): officially support Deno #3117

Conversation

pcattori commented May 6, 2022 • edited Loading

Docs

Testing Strategy

Manually testing

MichaelDeBoey left a comment • edited Loading

Choose a reason for hiding this comment

pcattori commented May 9, 2022

MichaelDeBoey commented May 9, 2022

pcattori commented May 9, 2022

MichaelDeBoey commented May 9, 2022

github-actions bot commented May 17, 2022

github-actions bot commented May 18, 2022

pcattori commented May 6, 2022 •

edited

Loading

MichaelDeBoey left a comment •

edited

Loading