Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(templates/deno): add missing typings to devDependencies #3256

Closed
wants to merge 1 commit into from

Conversation

machour
Copy link
Collaborator

@machour machour commented May 19, 2022

No description provided.

@MichaelDeBoey MichaelDeBoey changed the title chore(templates/deno): Add missing typings for React in devDependencies chore(templates/deno): add missing typings to devDependencies May 19, 2022
@MichaelDeBoey
Copy link
Member

According to @pcattori, this isn't necessary (see #3117 (comment))

We don't need @types/* nor typescript in devDependencies because users will be relying on Deno tools (like the VSCode Deno extension) to provide types. These tools will use import maps to find the appropriate types (e.g. templates/deno/.vscode/resolve_npm_imports.json).

In short, Deno does typechecking via a custom TS compiler implementation (not via tsc). That implementation doesn't grab types from node_modules/ at all.

@machour
Copy link
Collaborator Author

machour commented May 19, 2022

I am using WebStorm instead of VS Code, and it was complaining to me about this.
Turns out I needed to install the Deno plugin, sorry for the noise!

@machour machour deleted the deno/add-types-packages branch May 19, 2022 16:28
@machour machour removed the request for review from pcattori May 19, 2022 16:29
@MichaelDeBoey
Copy link
Member

@machour Had the same problem before indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants