-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot compile with picocli-shell-jline3 dependency using Maven #1291
Comments
@deining - copying you for information too. |
@sualeh Thank you for raising this! Will applications be able to work around this by explicitly adding this dependency to their POM? <dependency>
<groupId>org.jline</groupId>
<artifactId>jline</artifactId>
<version>3.16.0</version>
<scope>compile</scope>
</dependency> If so, we can try to fix this in the next release, but in the meantime add a note for this to the documentation. |
Here is the way I suggest: <dependency>
<groupId>info.picocli</groupId>
<artifactId>picocli-shell-jline3</artifactId>
<version>4.6.0</version>
<exclusions>
<exclusion>
<groupId>org.jline</groupId>
<artifactId>jline</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline</artifactId>
<version>3.17.1</version>
</dependency> |
…anged: Gradle configuration is switched (from 'implementation' to 'api') for 'org.jline:jline' dependency note: solves broken build issues for any Maven project that uses 'picocli-shell-jline3' version 4.6.0
@remkop - may I request a point release with this fix? |
Yes will do. |
… Gradle configuration is switched (from 'implementation' to 'api') for 'org.jline:jline' dependency note: solves broken build issues for any Maven project that uses 'picocli-shell-jline3' version 4.6.0
Thanks again for raising this! |
Sorry for messing up things here. A huge thanks to everyone involved in ironing this fault out so quickly. |
@deining No worries at all! 😉 |
…anged: Gradle configuration is switched (from 'implementation' to 'api') for 'org.jline:jline' dependency note: solves broken build issues for any Maven project that uses 'picocli-shell-jline3' version 4.6.0
…o be `api` scope" This reverts commit 35c06e7.
…le is changed: Gradle configuration is switched (from 'implementation' to 'api') for 'org.jline:jline' dependency" This reverts commit 4db977c.
…o be `api` scope" This reverts commit 35c06e7.
…le is changed: Gradle configuration is switched (from 'implementation' to 'api') for 'org.jline:jline' dependency" This reverts commit 4db977c.
Since the change to Fix gradle warnings, Maven compilation of any project with picocli-shell-jline3 as a dependency is broken, since the artifact published to The Central Repository has a changed the scope of transitive dependencies to jline - see the following changes to scope in the published pom.xml:
whereas in former versions of picocli it was
In order words, the change in how the Gradle dependency is defined has broken the Maven scope, and compilation fails.
The text was updated successfully, but these errors were encountered: