Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PicocliCommands.java:283: error: [Overrides] Varargs doesn't agree for overridden method #2169

Closed
vorburger opened this issue Dec 15, 2023 · 0 comments · Fixed by #2170
Closed
Labels
theme: shell An issue or change related to interactive (JLine) applications
Milestone

Comments

@vorburger
Copy link
Contributor

This is similar-ish to #2053, and related to #2054:

I'm (working in an internal environment where we are) running https://errorprone.info/ on this project, and it has found another bug:

third_party/java_src/picocli/picocli-shell-jline3/src/main/java/picocli/shell/jline3/PicocliCommands.java:283: error: [Overrides] Varargs doesn't agree for overridden method
    public Object invoke(CommandRegistry.CommandSession session, String command, Object[] args) throws Exception {
                  ^
    (see http://go/bugpattern/Overrides)
  Did you mean 'public Object invoke(CommandRegistry.CommandSession session, String command, Object... args) throws Exception {'?

I'll directly raise a PR to fix this, as it's trivial.

@cushon FYI

vorburger added a commit to vorburger/picocli that referenced this issue Dec 15, 2023
@remkop remkop added this to the 4.7.6 milestone Dec 16, 2023
@remkop remkop added the theme: shell An issue or change related to interactive (JLine) applications label Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: shell An issue or change related to interactive (JLine) applications
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants