Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ... vararg instead of array parameter to match overridden method signature #2170

Merged
merged 3 commits into from
Dec 16, 2023

Conversation

vorburger
Copy link
Contributor

fixes #2169

@vorburger
Copy link
Contributor Author

@remkop Hi! Wanna click Approve to Run workflow?

@remkop
Copy link
Owner

remkop commented Dec 16, 2023

Build seems to be failing with this error:

/home/runner/work/picocli/picocli/picocli-shell-jline3/src/test/java/picocli/shell/jline3/example/Example.java:137: error: cannot find symbol

> Task :picocli-shell-jline3:compileTestJava FAILED
            Builtins builtins = new Builtins(workDir, new ConfigurationPath(workDir.get(), workDir.get()), null);
                                                          ^
  symbol:   class ConfigurationPath
  location: class Example
1 error

FAILURE: Build failed with an exception.


* What went wrong:
Execution failed for task ':picocli-shell-jline3:compileTestJava'.
> Compilation failed; see the compiler error output for details.

@remkop remkop added this to the 4.7.6 milestone Dec 16, 2023
@remkop remkop added the theme: shell An issue or change related to interactive (JLine) applications label Dec 16, 2023
@vorburger
Copy link
Contributor Author

vorburger commented Dec 16, 2023

Build seems to be failing with this error:

That problem (above) was fixed with #2172.

This PR now (only) fails on Java 6, due to the problem shown on #2176 (comment)... let's look into that in #2173.

@vorburger vorburger mentioned this pull request Dec 16, 2023
@remkop remkop merged commit e6236f2 into remkop:main Dec 16, 2023
0 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: shell An issue or change related to interactive (JLine) applications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PicocliCommands.java:283: error: [Overrides] Varargs doesn't agree for overridden method
2 participants