-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the picocli jar OSGi friendly #734
Comments
I’d be happy to help. |
We just need to add some headers to the jar's manifest file. This is easily achievable with the [1] - https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin |
Yes please, a PR would be great! |
Note that picocli uses Gradle (gradle-4.10.2) to build though. The |
Merged into master. Please verify. |
FYI, 4.0.0-beta-2 has been released. It may take a few hours for Maven mirrors to update. |
@raducotescu Quick question: I notice that the |
I've used the default the plugin sets, which is the name of the folder where the `bnd.bnd` file is. It's just a name and doesn't really have much importance in the OSGi world but if you prefer you can change it to `<groupId>.<artifactName>` for the final release. Or it could stay like it is since it's anyways the name of the artifact, right?
|
I would like to use the picocli in an OSGi environment for a module of the Apache Sling project - see [0]. Currently, I've embedded the source code, but that makes our Sonar checks fail. Would it be possible to provide an OSGi-friendly jar? The effort should be minimal IMO and would really help us out, without any other implications for other consumers.
[0] - apache/sling-org-apache-sling-committer-cli#4
The text was updated successfully, but these errors were encountered: