[#734] Make the picocli jar OSGi friendly #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raducotescu
commented
Jun 18, 2019
raducotescu
commented
- added the bnd plugin to the build
- defined a bnd.bnd file to handle the package export
* added the bnd plugin to the build * defined a bnd.bnd file to handle the package export (fixes #734)
|
@remkop, it's the first time I interact with Gradle so if you see things to improve feel free to do them. I've tested the resulting bundle in an OSGi setup and everything worked fine. |
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
========================================
Coverage 93.9% 93.9%
Complexity 367 367
========================================
Files 2 2
Lines 5495 5495
Branches 1428 1428
========================================
Hits 5160 5160
Misses 144 144
Partials 191 191Continue to review full report at Codecov.
|
remkop
added
type: enhancement ✨
theme: module
remkop
added a commit
that referenced
this pull request
Jun 18, 2019
|
Please star the project if you like it! 😁 |
|
And again many thanks for the PR! |
remkop
added a commit
that referenced
this pull request
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.