Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect autocomplete if file name contains space #1473

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

NewbieOrange
Copy link
Contributor

By setting the bash separator to \n, COMPREPLY now contains file names with spaces without splitting them, and can autocomplete correctly.

Screenshot1

After some preliminary testing, only files with line feed \n in their name cannot be autocompleted correctly, but ls seem to behave the same, so looks good to me.

Screenshot2

This pull request will close #1458.

@remkop remkop added this to the 4.6.3 milestone Nov 23, 2021
@remkop remkop added theme: auto-completion An issue or change related to auto-completion type: enhancement ✨ labels Nov 23, 2021
@remkop
Copy link
Owner

remkop commented Nov 23, 2021

Thank you for another great contribution, @NewbieOrange !
I am looking at another PR related to autocompletion first, and I will merge yours after that.
Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: auto-completion An issue or change related to auto-completion type: enhancement ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad Autocomplete Output When Tab Completing a File With a Space
2 participants