Picocli 4.6.3 : autocompletion of directory names not working anymore

[philgdn]

I'm facing a regression with Picocli 4.6.3 : the autocompletion of filenames doesn't work anymore.

The help of my OdsManager app:

OdsManager extractLoadOds [-hV] [-p PROPERTIES] [JOBFILE [--maxErrorsByExtraction MAX_ERRORS] [--[no-]cleanBeforeExtract] [-f | -s SINCE]] [[--commitAfter <commitLoadAfter>]

When I enter OdsManager extractLoadOds on the command line, with Picocli 4.6.2 hitting the TAB twice I was getting the possibility to autocomplete directory names for the JOBFILE parameter:

• if I hit TAB twice I get the list of files and directories in the current directory
• if I then type jo TAB TAB (for the existing jobs/ directory)... I get no suggestions

This was working in 4.6.2 but doesn't work anymore in 4.6.3.

[remkop]

Thank you for raising this!
I will take a look.

[remkop]

I finally had some time to look at this.
This seems to be caused by this change: #1473: if I comment out the local IFS=$'\n' in the completion script section for the positional parameter, completion seems to work for partial directory names.

I need to spend more time debugging this.

[NewbieOrange]

Is this reproducible with https://raw.githubusercontent.com/remkop/picocli/master/src/test/resources/picocompletion-demo_completion.bash?

[philgdn]

Sorry I missed your message of September 1.

With the provided picocompletion-demo_completion.bash script I get the completion for the directory names

[NewbieOrange]

Can you provide a minimal example to reproduce the issue?

[philgdn]

Here are examples (not so minimal sorry) : Examples.zip

• SolifeOdsBatchManager_completion_462 was generated by Picocli 4.6.2 and works as expected
• SolifeOdsBatchManager_completion_463 was generated by Picocli 4.6.3 : autocompletion don't work for directories

To reproduce the problem (with SolifeOdsBatchManager_completion_463) in a directory containing files and directories type (for example a directory dir1 :

SolifeOdsBatchManager extractLoadOds d then TAB.

The autocompletion should complete the dir1 directory... but it doesn't

[remkop]

Hi @NewbieOrange, great to hear from you!
I would like to include a fix for this issue (#1644) in the picocli 4.7 release;
this ticket has been on my radar but I never got time to look at it... 😓

I believe the #1759 PR is related because it also looks at setting local IFS=$'\n' in the completion script.

[NewbieOrange]

@remkop after some debugging, the issue seems to be caused by COMPREPLY has been set with wrong IFS; and this should be fixed by #1759.

edit: @philgdn maybe you can test with #1759?

[remkop]

Oh awesome! 🤩
So, #1759 will also fix #1644?
Thank you for looking into this!

[philgdn]

@remkop after some debugging, the issue seems to be caused by COMPREPLY has been set with wrong IFS; and this should be fixed by #1759.

edit: @philgdn maybe you can test with #1759?

@NewbieOrange , here is the completion generated with the #1759 : SolifeOdsBatchManager_completion_1759.zip

Unfortunately it doen't work yet with directory names !

[NewbieOrange]

@remkop after some debugging, the issue seems to be caused by COMPREPLY has been set with wrong IFS; and this should be fixed by #1759.
edit: @philgdn maybe you can test with #1759?

@NewbieOrange , here is the completion generated with the #1759 : SolifeOdsBatchManager_completion_1759.zip

Unfortunately it doen't work yet with directory names !

Looks #1759 introduced another issue... Please try #1863

[philgdn]

@NewbieOrange , here is the completion generated with the #1863 : SolifeOdsBatchManager_completion_1863.zip

The completion of directory names works now !

BUT it is now the commands that doesn't work anymore.

• if I type SolifeOdsBatchManager extract then TAB (to get extractOds or extractLoadOds) no completion is suggested
• if I type SolifeOdsBatchManager then TAB the list of all commands is printed on the line

[NewbieOrange]

@philgdn can you try with #1863 again?

[philgdn]

@philgdn can you try with #1863 again?

@NewbieOrange , it's OK now : completion of commands AND directory names are working!

Thanks four your help!

[NewbieOrange]

@remkop fixed by #1863

[NewbieOrange]

Hi, @philgdn can you please retest with #1863? To fix the tests I made some changes ❤️

[philgdn]

@NewbieOrange , it's still OK: completion of commands AND directory names are working!