-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix path completion not working with directory names #1863
Conversation
4da5623
to
3ff446c
Compare
3ff446c
to
cbc3ecc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this!
I fixed an unrelated broken test, but now I see a number of failing tests for AutoComplete:
picocli.AutoCompleteHyphenatedCommandTest > testCompletionScript FAILED
org.junit.ComparisonFailure at AutoCompleteHyphenatedCommandTest.java:28
picocli.AutoCompleteTest > testBashify FAILED
org.junit.ComparisonFailure at AutoCompleteTest.java:1270
picocli.AutoCompleteTest > nestedSubcommands FAILED
org.junit.ComparisonFailure at AutoCompleteTest.java:192
picocli.AutoCompleteTest > basic FAILED
org.junit.ComparisonFailure at AutoCompleteTest.java:97
picocli.AutoCompleteTest > testBashifyWithExtras FAILED
org.junit.ComparisonFailure at AutoCompleteTest.java:12[82](https://github.com/remkop/picocli/actions/runs/3355881768/jobs/5560665264#step:8:83)
picocli.AutoCompleteTest > helpCommand FAILED
org.junit.ComparisonFailure at AutoCompleteTest.java:208
stty: /dev/tty: No such device or address
2319 tests completed, 6 failed, 27 skipped
Can you take a look?
f969c11
to
8450ceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NewbieOrange Thank you for making the tests pass!
Merged! |
@NewbieOrange question for you: does this PR also solve the problem mentioned in #1759 (spaces in completion candidates)? |
No it doesnt. Similar changes (like #1759, but it might need some changes) need to be implemented for that situation to work. |
Fixes #1644