chore(regex): add additional logging for isValidDependency failures
#29791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing regexes to match custom file formats, it may not be obvious why a valid regex may not be resulting in a match. This is often because we have written a perfectly correct regex which has matched the line(s), but then our `isValidDependency` check fails. To make it easier to discover this, we can add a TRACE log, and note that we will discard the dependency, giving suitable context for what is being rejected.
viceice
reviewed
Jun 21, 2024
rarkins
approved these changes
Jun 21, 2024
|
🎉 This PR is included in version 37.413.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds TRACE level logging, as per discussion on Renovate Slack.
Context
When writing regexes to match custom file formats, it may not be obvious
why a valid regex may not be resulting in a match.
This is often because we have written a perfectly correct regex which
has matched the line(s), but then our
isValidDependencycheck fails.To make it easier to discover this, we can add a TRACE log, and note
that we will discard the dependency, giving suitable context for what is
being rejected.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: