Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(regex): add additional logging for isValidDependency failures #29791

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

jamietanna
Copy link
Contributor

Changes

Adds TRACE level logging, as per discussion on Renovate Slack.

Context

When writing regexes to match custom file formats, it may not be obvious
why a valid regex may not be resulting in a match.

This is often because we have written a perfectly correct regex which
has matched the line(s), but then our isValidDependency check fails.

To make it easier to discover this, we can add a TRACE log, and note
that we will discard the dependency, giving suitable context for what is
being rejected.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

When writing regexes to match custom file formats, it may not be obvious
why a valid regex may not be resulting in a match.

This is often because we have written a perfectly correct regex which
has matched the line(s), but then our `isValidDependency` check fails.

To make it easier to discover this, we can add a TRACE log, and note
that we will discard the dependency, giving suitable context for what is
being rejected.
@rarkins rarkins enabled auto-merge June 21, 2024 08:43
@rarkins rarkins added this pull request to the merge queue Jun 21, 2024
Merged via the queue into renovatebot:main with commit 6b24abe Jun 21, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.413.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants