Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(regex): add additional logging for isValidDependency failures #29791

Merged
merged 3 commits into from
Jun 21, 2024
Merged

chore(regex): add additional logging for isValidDependency failures #29791

merged 3 commits into from
Jun 21, 2024

Commits on Jun 21, 2024

  1. chore(regex): add additional logging for isValidDependency failures 

    When writing regexes to match custom file formats, it may not be obvious
why a valid regex may not be resulting in a match.

This is often because we have written a perfectly correct regex which
has matched the line(s), but then our `isValidDependency` check fails.

To make it easier to discover this, we can add a TRACE log, and note
that we will discard the dependency, giving suitable context for what is
being rejected.
    @jamietanna
    jamietanna committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    437bd9b View commit details
    Browse the repository at this point in the history

  2. fixup! chore(regex): add additional logging for isValidDependency f… 

    …ailures
    @jamietanna
    jamietanna committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    dd7d5b5 View commit details
    Browse the repository at this point in the history

  3. fixup! fixup! chore(regex): add additional logging for `isValidDepend… 

    …ency` failures
    @jamietanna
    jamietanna committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    95c9afc View commit details
    Browse the repository at this point in the history