fix(git-url): fix SSH to HTTPS conversion for bitbucket-server #29527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Force git-url-parse to insert
/scm/
when converting SSH URLs to HTTPS onbitbucket-server
.Adjust
detectPlatform()
to detectbitbucket-server
from host type.Context
Fixes git submodules on BitBucket Server.
SSH URLs on BitBucket Server look like this:
ssh://git@git.my.com:7999/project/repo.git
.HTTPS URLs look like this:
https://git.mycompany.com/scm/proj/repo.git
.git-url-parse doesn't recognize the SSH URL as BitBucket Server. And it likely can't: the only hint is the default SSH port number, which can be changed, or can be used by other service.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: