Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git-url): fix SSH to HTTPS conversion for bitbucket-server #29527

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

amezin
Copy link
Contributor

@amezin amezin commented Jun 8, 2024

Changes

Force git-url-parse to insert /scm/ when converting SSH URLs to HTTPS on bitbucket-server.

Adjust detectPlatform() to detect bitbucket-server from host type.

Context

Fixes git submodules on BitBucket Server.

SSH URLs on BitBucket Server look like this: ssh://git@git.my.com:7999/project/repo.git.
HTTPS URLs look like this: https://git.mycompany.com/scm/proj/repo.git.

git-url-parse doesn't recognize the SSH URL as BitBucket Server. And it likely can't: the only hint is the default SSH port number, which can be changed, or can be used by other service.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added this pull request to the merge queue Jun 8, 2024
Merged via the queue into renovatebot:main with commit d560187 Jun 8, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.399.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants