-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(git/auth): fix insteadOf
for bitbucket-server
#29951
fix(git/auth): fix insteadOf
for bitbucket-server
#29951
Conversation
`bitbucket-server` can come only from host rules anyway.
This works only if default ports are used. A more correct solution is possible: almost all (if not all) platforms return both HTTP(S) and SSH git URLs in API. These URLs can be used to figure out base URLs for both protocols, and then perform translation (both in |
🎉 This issue has been resolved in version 37.436.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@@ -350,6 +350,27 @@ describe('util/git/auth', () => { | |||
GIT_CONFIG_VALUE_2: 'https://github.com:89/org/repo.git', | |||
}); | |||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get data info and report bugs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iam
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iam
Changes
Fix git submodule update on Bitbucket Server/Data Center.
Context
#29527 fixed dependency extraction, but update still fails - Renovate tries to clone submodules over SSH, because none of generated
url.*.instanceOf
matches.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: