feat(manager/helm-values): add image support in helm values manager #29828
+96
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
KyriosGN0
changed the title
viceice
requested changes
Jun 25, 2024
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
|
@secustor fixed that! |
viceice
reviewed
Jul 1, 2024
| @@ -0,0 +1,68 @@ | |||
| # Default values for test-chart. | |||
There was a problem hiding this comment.
Reduce to minimal size and inline to test
There was a problem hiding this comment.
what do you mean to inline? i should remove the file and pass the values in the test ?
Comment on lines
+14
to
+17
| const helmImageInsteadOfRepository = Fixtures.get( | ||
| 'values_with_image_instead_of_repo.yaml', | ||
| ); | ||
|
|
| currentItem.image === undefined | ||
| ) { | ||
| logger.debug('repository and image are both undefined'); | ||
| return null; |
|
@KyriosGN0 do you have time to continue this PR? |
|
@rarkins, yes i just don't understand what is it i should change ? |
Removed the added fixture files. Instead reduce the content as much as possible, and then inline it in the spec.ts file using renovate/lib/modules/manager/leiningen/extract.spec.ts Lines 149 to 161 in fa8d3ff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the
imageas viable option in helm-values manageras some charts use
imageand notrepositoryin the values.yamlContext
Some of our internal charts use image instead of repository
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: