-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/helm-values): add image support in helm values manager #29828
base: main
Are you sure you want to change the base?
feat(manager/helm-values): add image support in helm values manager #29828
Conversation
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
remove the closes keyword, this PR doesn't resolve that issue.
-
please add a use case to the PR description.
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@secustor fixed that! |
@@ -0,0 +1,68 @@ | |||
# Default values for test-chart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduce to minimal size and inline to test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean to inline? i should remove the file and pass the values in the test ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
const helmImageInsteadOfRepository = Fixtures.get( | ||
'values_with_image_instead_of_repo.yaml', | ||
); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline to test
currentItem.image === undefined | ||
) { | ||
logger.debug('repository and image are both undefined'); | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a test
@KyriosGN0 do you have time to continue this PR? |
@rarkins, yes i just don't understand what is it i should change ? |
Removed the added fixture files. Instead reduce the content as much as possible, and then inline it in the spec.ts file using renovate/lib/modules/manager/leiningen/extract.spec.ts Lines 149 to 161 in fa8d3ff
|
Changes
This PR adds the
image
as viable option in helm-values manageras some charts use
image
and notrepository
in the values.yamlContext
Some of our internal charts use image instead of repository
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: