Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager/helm-values): add image support in helm values manager #29828

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(manager/helm-values): add image support in helm values manager #29828

wants to merge 8 commits into from
+96 −4

Commits on Jun 24, 2024

  1. add check for if image or repostiry in matchesHelmValuesDockerHeuristic 

    Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
    @KyriosGN0
    KyriosGN0 committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    06921d6 View commit details
    Browse the repository at this point in the history

  2. fix by pnpm lint-fix 

    Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
    @KyriosGN0
    KyriosGN0 committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    53b24f3 View commit details
    Browse the repository at this point in the history

  3. add support for image in helm-values manager 

    Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
    @KyriosGN0
    KyriosGN0 committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a5f9bf3 View commit details
    Browse the repository at this point in the history

  4. fix lint issues 

    Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
    @KyriosGN0
    KyriosGN0 committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    3fa4fa6 View commit details
    Browse the repository at this point in the history

  5. updated readme for helm-values 

    Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
    @KyriosGN0
    KyriosGN0 committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    1319af0 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. added return null if both image and repository are undefined 

    Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
    @KyriosGN0
    KyriosGN0 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d54b975 View commit details
    Browse the repository at this point in the history

  2. remove extra line in readme 

    Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
    @KyriosGN0 @viceice
    KyriosGN0 and viceice committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6d6112c View commit details
    Browse the repository at this point in the history

  3. add test 

    Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
    @KyriosGN0
    KyriosGN0 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b13d7f7 View commit details
    Browse the repository at this point in the history