Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Ensure both trace fields are set if tracing is used #117

Merged
merged 1 commit into from
Nov 21, 2024
Merged

bugfix: Ensure both trace fields are set if tracing is used #117

merged 1 commit into from
Nov 21, 2024

Conversation

cbrewster
Copy link
Member

@cbrewster cbrewster commented Nov 21, 2024 •
edited
Loading

Why

If tracing is set, we expect traceparent and tracestate to be non-null on the server side. If there is no tracestate, an empty string is sufficient.

What changed

  • Default traceparent and tracestate to empty strings

Test plan

  • Tracing should work without the TS server rejecting these messages

@cbrewster cbrewster requested a review from a team as a code owner November 21, 2024 22:53
@cbrewster cbrewster requested review from masad-frost and removed request for a team November 21, 2024 22:53
@cbrewster
Copy link
Member Author

Current dependencies on/for this PR:

This comment was autogenerated by Freephite.

@cbrewster cbrewster added the bug Something isn't working label Nov 21, 2024
blast-hardcheese
blast-hardcheese approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ope

@cbrewster cbrewster merged commit df0e700 into main Nov 21, 2024
3 checks passed
@cbrewster cbrewster deleted the 11-21-bugfix_Ensure_both_trace_fields_are_set_if_tracing_is_used branch November 21, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blast-hardcheese blast-hardcheese blast-hardcheese approved these changes

@masad-frost masad-frost Awaiting requested review from masad-frost masad-frost is a code owner automatically assigned from replit/pid2-reviewers

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbrewster @blast-hardcheese