Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/tidy server codegen #119

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

blast-hardcheese
Copy link
Contributor

Why

Preparing to upgrade server to protocol v2

What changed

  • Generalizing some common functionalities between client and server codegen
  • Switching from accumulating individual lines and trying to carefully juggle indent levels to reindent(f"""\ ....

Test plan

Describe what you did to test this change to a level of detail that allows your reviewer to test it

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner November 22, 2024 00:22
@blast-hardcheese blast-hardcheese requested review from jackyzha0 and removed request for a team November 22, 2024 00:22
@blast-hardcheese blast-hardcheese merged commit c78c653 into main Nov 26, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/chore/tidy-server-codegen branch November 26, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants